Hi Soeren, I can definitely relate to the owning of infrastructure idea. :)
However, I specifically asked about this in the past and got a different response. This is what Uwe said on the 3rd of March: 18:07 #sigrok: <@uwe_> sandberg: pull-requests are preferred, or just URLs here to your repo, ML patchsets mean a lot more hassle generally He has made similar comments on the mailinglist as well (see for example the "Submitting protocol decoder without accompanying sniff" thread. Cheers, Andreas On Wed, Mar 25, 2020 at 9:56 AM Soeren Apel <soe...@apelpie.com> wrote: > Hello Andreas, > > While I appreciate your input, your understanding is not > correct. The preferred way is to > > 1) Post patches on the IRC channel (and lurk there for questions) > 2) Mail patches to the mailing list > > (see > https://sigrok.org/gitweb/?p=libsigrok.git;a=blob;f=HACKING;hb=HEAD#l15 > ) > > We only have a github repo because people were asking for it. > PRs are only existing because we have no way to prevent them. > > As for CI: https://sigrok.org/jenkins/ > > It's used to build the nightlies and the AppImages, too. > > Why do we do this? We're the type of people who want to be > 100% in control of the infrastructure they're using :) > > Regards > -Soeren > > > On Wed, 2020-03-25 at 09:10 +0000, Andreas Sandberg wrote: > > Hi all, > > > > My understanding is that the preferred way to post patches to Sigrok > > is to create a pull request on GitHub. What do people think about > > enabling CI pull requests? > > > > As far as I can tell, there are basically two options. Either enable > > configure Jenkins to build pull requests (I think this involves > > adding a plugin and configuring some webhooks), or we enable Travis. > > > > I played around with Travis in my own fork and it seems to work well. > > I have only tried it for Linux (clang and gcc), but it should be > > possible to build on Windows and OSX as well. Feel free to have a > > look here [1]. > > > > Cheers, > > Andreas > > > > [1] https://github.com/andysan/libsigrok/tree/travis > > _______________________________________________ > > sigrok-devel mailing list > > sigrok-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/sigrok-devel > >
_______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
