On Thu, 2020-04-16 at 15:22 +0200, Wolfram Sang wrote:
>
>  if(ENABLE_STACKTRACE)
>       # Needed to resolve dladdr.
>       list(APPEND PULSEVIEW_LINK_LIBS "-ldl")
> +     link_libraries("-no-pie -fno-pie")
>  endif()

May I suggest you add another change "for good measure", and
replace the open coded -ldl spec with ${CMAKE_DL_LIBS} which is
more portable? Because you happen to touch the CMakeLists.txt
file anyway. (If I did that, we'd create two submissions which
would conflict -- granted, easy to resolve, but not necessary).

Of course this can also be done after your stacktrace series hit
mainline. Either approach can get us there.


virtually yours
Gerhard Sittig
--
     If you don't understand or are scared by any of the above
             ask your parents or an adult to help you.


_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel

Reply via email to