Hi Timo,

nice job! :)

You might want to add support for SmuView? Then you want to add a mutex 
(GMutex) to make the serial read/write thread safe.
Background is that data acquisition and getting/setting of config keys are 
running in separate threads in SmuView.
Have a look at the arachnid-labs-re-load-pro driver (acquisition_mutex) or the 
korad-kaxxxxp driver (rw_mutex) for examples.

For bonus points you want to add the SR_CONF_LIST capability to the 
SR_CONF_REGULATION config key and return something like {"CV", "CC", "UR", ...}.
This is useful for sigrok-cli and very useful for SmuView. See also the 
arachnid-labs-re-load-pro driver for an example.

But wait, there are extra bonus points :)
When the status of the device changes (e.g. entering over current protection, 
changing the output state, etc.) you can send a meta package, so that SmuView 
can show this change or sigrok-cli print a message to the terminal.
This is already implemented in some of the drivers, like 
arachnid-labs-re-load-pro and korad-kaxxxxp.

Cheers
Frank



_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel

Reply via email to