Hello, Thanks for reaching out and wanting to contribute to our project.
Please keep in mind that using bytes to store the analog data values may work for oszilloscopes but not for other data sources. This means we'd need to be able to have both types of storage and PV needs to be able to choose the appropriate one somehow. What exactly are you trying to improve, performance-wise? I suggest you discuss any intended architecture changes with us first, it's always unfortunate having to turn down merge requests because the submitter didn't communicate with us first to agree on a suitable architecture. As for your questions: > 1. whats the status of this work? I'm not sure. Maybe open an issue on https://github.com/mrnuke/libsigrok and ask? > 2. is there code i can reuse? see above > 3. what are the challenges? Not many people care about high-precision analog because fetching the raw data from the data acquisition device is "good enough" for most people. It's a big effort and unless someone has vested interest in the matter, it won't be worked on. All the best, -Soeren On Sun, 2020-08-02 at 16:08 +0200, milan hauth wrote: > im trying to improve performance of pulseview > and therefore i need raw values from the libsigrok driver > > my assumptions are > * fixed point math / integer arithmetics is faster than float > * multiplication is faster than division > ** slow division can be replaced with fast bitshift > * benefits of float are not needed in my app > (analog oscilloscope with 8bit vertical resolution, linear data) > * scale and offset calculations should be done only once > in the whole data pipeline from sensor to GUI (raw to pixel in just one > step) > * smaller data types perform better (memory speed) > * fourier transform can be optimized to use the raw datatypes, > like "kiss fft" for 16bit fixed point FFT > * in a GUI app like pulseview, the real values (voltages) > are needed much less often than "pixel values" > so the real values can be calculated on demand > > i found this wiki entry > https://sigrok.org/wiki/High_precision_analog > #Exact_representation_of_raw_data_and_metadata > > with this link > https://gitorious.org/~mrnuke/sigrok/libsigrok/commits/prec > "for details of implementation proposal" > > .. but the link is broken > https --> SSL_ERROR_RX_RECORD_TOO_LONG > http --> Not Found > archive/cache --> not found > other repos --> not found > > so my questions are: > 1. whats the status of this work? > 2. is there code i can reuse? > (where is the "implementation proposal" by mrnuke?) > 3. what are the challenges? > (or, why is this not implemented yet? except being low priority) > > > _______________________________________________ > sigrok-devel mailing list > sigrok-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/sigrok-devel _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
