On Sun, 2020-08-16 at 11:48 +0200, Helge Kruse wrote:
>
> Hallo,
>
> this is my second try to contribute to the sigrok project. I
> found in the wiki. "Send the decoder (preferrably as a patch
> against the current git HEAD of libsigrokdecode) to the
> sigrok-devel mailing list". So I try this here.
When in doubt, also check the doc files that come with the source
which you modify or extend. In the libsigrokdecode case it's the
HACKING file in the top level of the source tree. The order of
preference is IRC communication and public git URLs, ML patches
only after that, and maybe github PRs though I never got why some
people feel they cannot live without those. You have already been
on IRC, please consider continuing that for a more lively
discussion or interaction.
There is no need to send patches to the list when your code
already resides in a public repo. In that case the URL is fully
sufficient, and transparently keeps working for updated patches
which attachments don't. It's also an unfortunate fact that many
mail clients mangle and break the content that they have been
given by their users.
When sending patches, please do consider sending full commits and
not just diffs. The latter lack essential information (authorship
and a description of what's happening and more importantly why),
which makes review more difficult, and results in unnecessary
additional work on the maintainers' side.
> I am working on the AVR_ISP decoder.
>
> In the first step I have replaced the number literals by some
> kind of enumeration as recommended on the same wiki page.
> Further I fixed an annotation index. The index for "programming
> enable" was errornously used instaed of the index for
> "warning".
>
> The patches for libsigrokdecode and sigroktest are attached.
> When these are accepted I plan to update to the new commit and
> provide the next patches that extend the functionality of the
> decoder.
All of this work was done before, and I was waiting for your ACK
so that I could take your previous version. You may have missed
that part of the conversation perhaps when you started diving
into git literature. :-]
Did not take your recent version attached to the email message,
since meta information was missing, and the previous version
already contained everything. Have pushed the commits that I
prepared two weeks ago instead. Which also covers the RLB, REEM,
RP, LPMP, WP annotations (EEPROM address calculation needed a
fix, please check recent master for correctness).
virtually yours
Gerhard Sittig
--
If you don't understand or are scared by any of the above
ask your parents or an adult to help you.
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
