On Sun, 2020-08-02 at 19:44 +0200, milan hauth wrote:
>
> here is a micro bug in libsigrok/src/analog.c
>
> --
>
> analog->encoding->offset.p / (float)analog->encoding->offset.q == 0
>
> is the same as
>
> analog->encoding->offset.p == 0
>
> cos q is an integer and can never be infinity
>
> --
>
> and
>
> analog->encoding->scale.p == 1
> && analog->encoding->scale.q == 1
>
> should be
>
> analog->encoding->scale.p == analog->encoding->scale.q
Would have been nice if you could provide more context. Not sure
if I have looked at the spots that you meant to refer to in that
file. The mail content was not "the patch" which the subject has
promised.
Why do you consider these instances "a bug" (regardless how
micro)? Sure you can consider them an inefficiency if you will.
But is the operation of the code in question flawed, or was the
implementation just unexpected to you? Got more information?
virtually yours
Gerhard Sittig
--
If you don't understand or are scared by any of the above
ask your parents or an adult to help you.
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
