On Sun, 2020-11-22 at 16:17 -0500, Ben Gardiner wrote:
>
> Expand the list of characters that will be recognized by the
> seven segment decoder to include many display character
> 'encodings.' Including some punctuation characters and tricky
> letters like W and V.
>
> [ ... ]
>
> https://github.com/BenGardiner/sigrok-dumps/commit/fac5f2c3c88c9087e1c0c84d8877583126a59dd7
> https://github.com/BenGardiner/sigrok-test/commit/e50d5cedfcda9aee82f6108531e4b2aa059f58e2
> https://github.com/BenGardiner/libsigrokdecode/commit/05930e256fe273ba55628358121a67bacaaef89b
The idea of covering more "printables" (especially alnum) sounds
good to me. But is there a reason for the (perceived by me)
arbitrary sort order? From the maintenance perspective I'd expect
something like ASCII (see 'man ascii'). Granted that for the
7-segment case it'd be most appropriate to "fold" upper and lower
case letters into one common alnum group. But I'd definitely
expect punct then digits then alpha order during maintenance of
the PD. Or is it just me?
Just tell if you want to provide a followup commit that I can
squash, or whether you want me to shuffle the order. The "show
unknown" option also looks useful to me. And I'd pick all of it
(the segments comment, too, very useful). Assuming that the test
passes, haven't run it yet. PD output shouldn't change when the
implementation changes the lookup table's order.
virtually yours
Gerhard Sittig
--
If you don't understand or are scared by any of the above
ask your parents or an adult to help you.
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
