Le lun. 3 janv. 2022 à 06:05, Stefan Brüns
<stefan.bru...@rwth-aachen.de> a écrit :
>
> On Sonntag, 2. Januar 2022 18:32:16 CET Fabrice Fontaine wrote:
> }
> >
> > -Glib::TimeVal Header::start_time() const
> > +Glib::DateTime Header::start_time() const
> > {
> > - return Glib::TimeVal(
> > - _structure->starttime.tv_sec,
> > - _structure->starttime.tv_usec);
> > + Glib::DateTime time;
> > + time.create_now_utc(_structure->starttime.tv_sec);
>
> Loosing precision. You need something like
> ```
> time = time.add_seconds(_structure->starttime.tv_usec / 1.0e6);
> ```
>
>
> > # The C++ bindings need glibmm.
> > -SR_PKG_CHECK([glibmm], [SR_PKGLIBS_CXX], [glibmm-2.4 >= 2.32.0])
> > +SR_PKG_CHECK([glibmm], [SR_PKGLIBS_CXX], [glibmm-2.68 >= 2.68.0])
> > AS_IF([test "x$sr_have_glibmm" != xyes],
> > [SR_APPEND([sr_cxx_missing], [', '], [glibmm])])
>
> Many distributions still only have glibmm-2.4, and Glib::DateTime is available
> since glibmm-2.4 >= 2.26 (API compatible). Please keep backwards
> compatibility.
Thanks for your review, I'll send a v2.
>
> Stefan
>
> --
> Stefan Brüns / Bergstraße 21 / 52062 Aachen
> home: +49 241 53809034 mobile: +49 151
> 50412019_______________________________________________
> sigrok-devel mailing list
> sigrok-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/sigrok-devel
Best Regards,
Fabrice
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
