Thanks for this PR, very cool! While I do not have a legacy DSLogic, I do have a U3Pro16, so let me know if you need any help testing your changes. I left a comment on the GitHub PR with some initial findings I found.
On Thursday, January 13, 2022 2:11:19 PM EST Christian Eisendle wrote: > Hi all, > > as announced in an earlier email, I added support for dreamsourcelab > DSLogic U3Pro16 to libsigrok. It is a logic analyzer with up to 1GHz > sample rate, 16 channels, buffered and streaming mode support and USB3 > interface. (https://sigrok.org/wiki/DreamSourceLab_DSLogic_U3Pro16) > > The support has been added to existing dreamsourcelab-dslogic driver > with some runtime diversity since the U3Pro16 has a new API which is > not fully backward-compatible with the legacy dreamsource logic devices. > > Still, most of the logic is common which was the reason to combine all > dslogic devices into one driver. I don't own a legacy dslogic device to > test for regressions, but if there is somebody out there who has, I > would appreciate if some testing with the new combined driver can be > done. > > I'm also fine with segregating the two drivers into a dedicated > dreamsourcelab-dslogicpro driver in order to have the original driver > untouched. > > The PR is on github > (https://github.com/sigrokproject/libsigrok/pull/170). > > Thanks, > Christian. > > > > _______________________________________________ > sigrok-devel mailing list > sigrok-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/sigrok-devel _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
