Hi all, I submitted a pull request to libsigrok on GitHub last year that rewrites a significant portion of the FTDI-LA driver to make it more reliable, support new features on some chips, and drop support for other chips that never worked properly:
https://github.com/sigrokproject/libsigrok/pull/145 As of yet, though, no one has reviewed the PR or told me what needs to change to get it merged. I'm sending this email in the hopes it'll reach someone who has time and motivation to help me get this code into sigrok. I'm also happy to send the commits from the PR as patches to this list, if that's easier to review. The PR is quite large by number of lines, and it touches an existing driver which means merging it risks regressions, so I certainly understand why no one would be keen to review it. However, I do think the review will be easier than it might seem for a few reasons: 1. It consists of multiple individual commits, each of which is well-documented and reviewable in isolation. 2. It's not an early-stage "RFC"-type PR: the code is fully-functional, polished, and as ready for merging as I can make it. I have compared it to the current driver with real hardware and found no regressions. 3. Regressions are less of a concern since, as the PR and commit messages describe, much of the FTDI-LA functionality is outright broken in its current state. Thanks for all you do to maintain sigrok! It's a great project, and I'd love to help make this piece of it better. -Tom _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
