Guys, Paul has been asking for a PR for 3 weeks. Can someone help him? -Chris ________________________________ From: Paul Kasemir <paul.kase...@gmail.com> Sent: Saturday, October 8, 2022 1:41 PM To: sigrok-devel@lists.sourceforge.net <sigrok-devel@lists.sourceforge.net> Subject: Re: [sigrok-devel] Can we finally merge link-mso19 hardware support [PR-144].
Is someone out there? Anyone? I would really like to get the mso19 support merged, or at least some comments on the PR. Pretty please. https://github.com/sigrokproject/libsigrok/pull/144<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsigrokproject%2Flibsigrok%2Fpull%2F144&data=05%7C01%7C%7Cb2ea429243cf40c47b0708daa96def9a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638008586911939137%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=iItk4PiaaBNEX0Nwv%2FIpXBOp7d3vM%2Ba7uGmY2Wir9dU%3D&reserved=0> Thanks, Paul On Mon, Sep 26, 2022 at 4:20 PM Paul Kasemir <paul.kase...@gmail.com<mailto:paul.kase...@gmail.com>> wrote: Come on guys. Can I please get a review for this and merge? I'm a bit disappointed in the lack of ability to get things reviewed and merged... Please review https://github.com/sigrokproject/libsigrok/pull/144<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsigrokproject%2Flibsigrok%2Fpull%2F144&data=05%7C01%7C%7Cb2ea429243cf40c47b0708daa96def9a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638008586911939137%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=iItk4PiaaBNEX0Nwv%2FIpXBOp7d3vM%2Ba7uGmY2Wir9dU%3D&reserved=0> Thanks, Paul On Wed, Sep 21, 2022 at 9:46 AM Paul Kasemir <paul.kase...@gmail.com<mailto:paul.kase...@gmail.com>> wrote: Why has nobody looked at this yet? Can I get a little help merging this so I don't have to keep rebasing it forever? Pretty please review this: https://github.com/sigrokproject/libsigrok/pull/144<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsigrokproject%2Flibsigrok%2Fpull%2F144&data=05%7C01%7C%7Cb2ea429243cf40c47b0708daa96def9a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638008586911939137%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=iItk4PiaaBNEX0Nwv%2FIpXBOp7d3vM%2Ba7uGmY2Wir9dU%3D&reserved=0> Thanks, Paul On Wed, Sep 14, 2022 at 9:23 AM Paul Kasemir <paul.kase...@gmail.com<mailto:paul.kase...@gmail.com>> wrote: I made this PR a long time ago. I've rebased and retested the change and it still works. https://github.com/sigrokproject/libsigrok/pull/144<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsigrokproject%2Flibsigrok%2Fpull%2F144&data=05%7C01%7C%7Cb2ea429243cf40c47b0708daa96def9a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638008586911939137%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=iItk4PiaaBNEX0Nwv%2FIpXBOp7d3vM%2Ba7uGmY2Wir9dU%3D&reserved=0> Thanks, Paul -- Engineering Power - A glowing pool of excellence. Lets take a swim. -- Engineering Power - A glowing pool of excellence. Lets take a swim. -- Engineering Power - A glowing pool of excellence. Lets take a swim. -- Engineering Power - A glowing pool of excellence. Lets take a swim.
_______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
