Hi,

> Sent: Saturday, December 03, 2022 at 10:29 AM
> From: "Rene Kita" <m...@rkta.de>
> > 1- avoid bundling an assignment in a conditional, `if ((var = func()) > 
> > other_var) ....`
>
> Indicating that it indeed is meant to be an assignment is usually done
> by wrapping it in parentheses.

That looks to me like a "workaround" - I really see no advantage to cramming 
all that code on one line. Terseness sacrifices readability in this case IMO.


> The colon should stick to the left.

Took me a second to understand (I wasn't seeing the "^^"), but agreed, will 
update the PR.

Thanks,


_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel

Reply via email to