Hi again, User fenugrec has made a review of my changes (over at github) which lead to some improvements. I've also made sure that there are no compiler warnings and have also removed a pre-existing warning.
Also, any opinions (from anyone) on adding the new configuration keys mentioned below? Best regards, Mikael Den lör 21 jan. 2023 15:15Mikael Djurfeldt <mik...@djurfeldt.com> skrev: > Hi, > > libsigrok:s rdtech-dps driver currently has support for the Riden devices > RD6006, RD6012 and RD6018. > > I've recently submitted support for RD6006P and RD6012P here: > > https://github.com/sigrokproject/libsigrok/pull/205 > > Also, all of these devices both have a system temperature and battery > temperature (as measured by an external battery temperature probe during > charging) reading. It would be convenient to be able to get those displayed > in the RDTech GUI in Smuview. Therefore, I'm considering adding the > configuration keys SR_CONF_SYSTEM_TEMPERATURE and > SR_CONF_BATTERY_TEMPERATURE to libsigrok.h. Would this make sense? Any > chance that this, together with corresponding changes in the rdtech-dps api > would be accepted? > > Best regards, > Mikael Djurfeldt > >
_______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
