Hi!

I'll have a look and review the PR.

Dan, before you go and write a completely new system, I'd like to note
there already is a test suite for the decoders that would have covered
this:

https://github.com/sigrokproject/sigrok-test
https://github.com/sigrokproject/sigrok-dumps

Or did you have anything more elaborate in mind? I mean, the sigrok-test
itself could have some of the tests embedded, but the dumps can be
problematic...

Automation: the multiple repo scheme complicates things. There is
sigrok-build that I believe runs the tests. I was actually thingking a
bot that checks every new PR change in all repos and creates a new
integration branch/PR for it on the sigrok-build to run the tests
together. The output could possibly be also used for testing on
different platforms for reporters that don't have the ability to compile
their own (TBH it's a chore, especially on non-linux).


Helge, if you don't mind, I suggest to open a PR into these two
repositories as well, putting the dump into sigrok-dumps repository and
the test into sigrok-test repo.

Cheers,
Ladislav


On Tue, Dec 09, 2025 at 09:55:56PM +0100, Dan Horák wrote:
> On Mon, 8 Dec 2025 19:01:16 +0100
> Helge Kruse via sigrok-devel <[email protected]> wrote:
> 
> > Hi,
> > 
> > I have found a problem with the SD card decoder while implementing a 
> > driver stack for an embedded platform. When the SD card doesn't send a 
> > response, the host controller sends the next command after a timeout. 
> > But the decoder expects a response and decodes the next token as a 
> > response. This is a bug.
> > 
> > The example trace file as well as the fix is in the pull request
> > https://github.com/sigrokproject/libsigrokdecode/pull/127
> 
> also this might be a good case to think about tests, ideally automated.
> I will try to come up with something, using my know-how from an
> enterprise Linux distro world :-)
> 
> 
>               Dan
> 
> 
> _______________________________________________
> sigrok-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/sigrok-devel

-- 
S pozdravem Ladislav "Krakonoš" Láska                http://www.krakonos.org/


_______________________________________________
sigrok-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sigrok-devel

Reply via email to