** Summary changed: - [request] Sikuli functions like click should accept java.awt.Rectangle/Point as parameter + [1.1.4] functions like click should should throw exception with wrong target type
-- You received this bug notification because you are a member of Sikuli Drivers, which is subscribed to Sikuli. https://bugs.launchpad.net/bugs/1382653 Title: [1.1.4] functions like click should should throw exception with wrong target type Status in Sikuli: Fix Committed Bug description: Probably i'm stupid, but twice now I've tried to call region.click(rect) where rect is java.awt.Rectangle, which is not a supported target type. The function simply does nothing and returns 0 (which i ignore). Don't you suppose it would be better if it throws FindFailed? or else UnsupportedTargetType? private <PSIMRL> Location getLocationFromTarget(PSIMRL target) throws FindFailed { if (target instanceof Pattern || target instanceof String || target instanceof Image) { Match m = find(target); if (m != null) { if (isOtherScreen()) { return m.getTarget().setOtherScreen(scr); } else { return m.getTarget(); } } return null; <======== SHOULD BE A THROW FINDFAILED } if (target instanceof Match) { return ((Match) target).getTarget(); } if (target instanceof Region) { return ((Region) target).getCenter(); } if (target instanceof Location) { return new Location((Location) target); } return null; <======== SHOULD BE A THROW BAD TARGET TYPE } I can't see any situation where return null is helpful. I think a throw is better. To manage notifications about this bug go to: https://bugs.launchpad.net/sikuli/+bug/1382653/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~sikuli-driver Post to : [email protected] Unsubscribe : https://launchpad.net/~sikuli-driver More help : https://help.launchpad.net/ListHelp
