Revision: 1853
Author: [email protected]
Date: Tue Feb 16 05:15:45 2010
Log: Fixed a few PMD warnings
http://code.google.com/p/simal/source/detail?r=1853
Modified:
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/SparqlQueryPage.java
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/ToolsPage.java
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/doap/DoapFormPage.java
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/panel/SourceRepositoriesPanel.java
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/simal/AddReviewPanel.java
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/widgets/WookieServerConnection.java
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/widgets/WookieWidgetGalleryPanel.java
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/widgets/WookieWidgetPanel.java
=======================================
---
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/SparqlQueryPage.java
Mon Feb 15 15:17:43 2010
+++
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/SparqlQueryPage.java
Tue Feb 16 05:15:45 2010
@@ -16,7 +16,6 @@
*/
package uk.ac.osswatch.simal.wicket;
-import org.apache.wicket.PageParameters;
import org.apache.wicket.markup.html.form.TextArea;
import org.apache.wicket.model.PropertyModel;
@@ -41,7 +40,7 @@
/**
* Create default SPARQL query page
*/
- public SparqlQueryPage(PageParameters parameters) {
+ public SparqlQueryPage() {
super();
TextArea<SparqlQueryInputModel> sparqlQueryField = new
TextArea<SparqlQueryInputModel>(
=======================================
---
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/ToolsPage.java
Fri Jan 8 09:33:39 2010
+++
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/ToolsPage.java
Tue Feb 16 05:15:45 2010
@@ -21,7 +21,6 @@
import java.io.FileNotFoundException;
import java.io.IOException;
import java.net.MalformedURLException;
-import java.util.Collection;
import java.util.Iterator;
import
org.apache.wicket.extensions.ajax.markup.html.form.upload.UploadProgressBar;
@@ -55,7 +54,6 @@
import uk.ac.osswatch.simal.wicket.foaf.ExhibitPersonBrowserPage;
import uk.ac.osswatch.simal.wicket.tools.OhlohFormInputModel;
import uk.ac.osswatch.simal.wicket.widgets.Widget;
-import uk.ac.osswatch.simal.wicket.widgets.WookieServerConnection;
import uk.ac.osswatch.simal.wicket.widgets.WookieWidgetGalleryPanel;
import uk.ac.osswatch.simal.wicket.widgets.WookieWidgetPanel;
import uk.ac.osswatch.simal.wicket.widgets.Widget.Instance;
@@ -313,11 +311,9 @@
if (upload != null) {
File newFile = new File(getUploadFolder(),
upload.getClientFileName());
- if (newFile.exists()) {
- if (!Files.remove(newFile)) {
- throw new IllegalStateException("Unable to overwrite "
+ if (newFile.exists() && !Files.remove(newFile)) {
+ throw new IllegalStateException("Unable to overwrite "
+ newFile.getAbsolutePath());
- }
}
try {
=======================================
---
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/doap/DoapFormPage.java
Sun Nov 22 16:35:40 2009
+++
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/doap/DoapFormPage.java
Tue Feb 16 05:15:45 2010
@@ -133,11 +133,9 @@
if (upload != null) {
File newFile = new File(getUploadFolder(),
upload.getClientFileName());
- if (newFile.exists()) {
- if (!Files.remove(newFile)) {
- throw new IllegalStateException("Unable to overwrite "
- + newFile.getAbsolutePath());
- }
+ if (newFile.exists() && !Files.remove(newFile)) {
+ throw new IllegalStateException("Unable to overwrite "
+ + newFile.getAbsolutePath());
}
try {
=======================================
---
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/panel/SourceRepositoriesPanel.java
Tue Jun 23 16:38:34 2009
+++
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/panel/SourceRepositoriesPanel.java
Tue Feb 16 05:15:45 2010
@@ -38,8 +38,6 @@
*/
public class SourceRepositoriesPanel extends Panel {
private static final long serialVersionUID = -2031486948152653715L;
- private static final Logger logger = LoggerFactory
- .getLogger(SourceRepositoriesPanel.class);
public SourceRepositoriesPanel(String panelId,
Set<IDoapRepository> repositories) {
=======================================
---
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/simal/AddReviewPanel.java
Mon Nov 23 01:02:16 2009
+++
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/simal/AddReviewPanel.java
Tue Feb 16 05:15:45 2010
@@ -77,7 +77,7 @@
this.inputModel = new ReviewFormInputModel(project, reviewer);
setOutputMarkupId(true);
add(new NewReviewLink("newLink"));
- add(new AddReviewForm("reviewForm", project));
+ add(new AddReviewForm("reviewForm"));
}
/**
@@ -169,7 +169,7 @@
private final class AddReviewForm extends Form<FoafFormInputModel> {
private static final long serialVersionUID = 2931852197898067993L;
- public AddReviewForm(String id, IProject project) {
+ public AddReviewForm(String id) {
super(id, new CompoundPropertyModel<FoafFormInputModel>(inputModel));
setOutputMarkupId(true);
=======================================
---
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/widgets/WookieServerConnection.java
Thu Dec 17 13:42:01 2009
+++
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/widgets/WookieServerConnection.java
Tue Feb 16 05:15:45 2010
@@ -21,7 +21,6 @@
import java.io.OutputStreamWriter;
import java.io.Serializable;
import java.io.UnsupportedEncodingException;
-import java.net.ConnectException;
import java.net.MalformedURLException;
import java.net.URL;
import java.net.URLConnection;
=======================================
---
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/widgets/WookieWidgetGalleryPanel.java
Tue Feb 16 01:53:18 2010
+++
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/widgets/WookieWidgetGalleryPanel.java
Tue Feb 16 05:15:45 2010
@@ -28,8 +28,6 @@
import org.apache.wicket.markup.repeater.RepeatingView;
import org.apache.wicket.model.IModel;
import org.apache.wicket.model.Model;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import uk.ac.osswatch.simal.rdf.SimalException;
import uk.ac.osswatch.simal.wicket.UserApplication;
=======================================
---
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/widgets/WookieWidgetPanel.java
Sun Dec 13 15:18:48 2009
+++
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/widgets/WookieWidgetPanel.java
Tue Feb 16 05:15:45 2010
@@ -28,7 +28,6 @@
*/
public class WookieWidgetPanel extends Panel {
private static final long serialVersionUID = 1L;
- private static final Logger logger =
LoggerFactory.getLogger(WookieWidgetPanel.class);
/**
* Create a default Wookie Widget.
--
You received this message because you are subscribed to the Google Groups "Simal
Commits" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/simal-commits?hl=en.
