Revision: 1854
Author: [email protected]
Date: Tue Feb 16 10:06:22 2010
Log: Fixed more PMD warnings
http://code.google.com/p/simal/source/detail?r=1854

Modified:
/trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/panel/PersonListPanel.java /trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/panel/SourceRepositoriesPanel.java /trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/report/ProjectsSummaryReportPage.java /trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/widgets/InstantiateWidgetPage.java /trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/widgets/WookieWidgetPanel.java

=======================================
--- /trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/panel/PersonListPanel.java Tue Feb 16 01:53:18 2010 +++ /trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/panel/PersonListPanel.java Tue Feb 16 10:06:22 2010
@@ -128,16 +128,7 @@
   @SuppressWarnings("unchecked")
 private void addPersonList(Set<IPerson> people, int numberOfPeople) {
     List<AbstractColumn> columns = new ArrayList<AbstractColumn>();
- columns.add(new LinkPropertyColumn(new Model("Name"), "label", "label") {
-               private static final long serialVersionUID = 1L;
-
-       @Override
-      public void onClick(Item item, String componentId, IModel model) {
-        IPerson person = (IPerson) model.getObject();
-        getRequestCycle().setResponsePage(new PersonDetailPage(person));
-      }
-
-    });
+ columns.add(new NameLinkPropertyColumn(new Model("Name"), "label", "label"));

     columns.add(new PropertyColumn(new Model("EMail"), "email", "email") {
                private static final long serialVersionUID = 1L;
@@ -165,28 +156,7 @@
                }
     });

- columns.add(new PropertyColumn(new Model("Project"), "projects", "projects") {
-               private static final long serialVersionUID = 1L;
-
-               @Override
- public void populateItem(Item cellItem, String componentId, IModel model) {
-               Iterator<IProject> projects;
-                       try {
-                               projects = 
((IPerson)model.getObject()).getProjects().iterator();
-                       StringBuffer label = new StringBuffer();
-                               while (projects.hasNext()) {
-                               IProject project = projects.next();
-                               label.append(project.getLabel());
-                               if (projects.hasNext()) {
-                                       label.append(", ");
-                               }
-                       }
-                   cellItem.add(new Label(componentId, label.toString()));
-                       } catch (SimalRepositoryException e) {
-                               cellItem.add(new Label(componentId, "ERROR"));
-                       }
-        }
-    });
+ columns.add(new ProjectsPropertyColumn(new Model("Project"), "projects", "projects"));

     dataProvider = new SortablePersonDataProvider(people);
dataProvider.setSort(SortablePersonDataProvider.SORT_PROPERTY_LABEL, true);
@@ -215,6 +185,65 @@
     this.people.add(person);
   }

+  /**
+   *
+   */
+  private final class NameLinkPropertyColumn extends LinkPropertyColumn {
+    private static final long serialVersionUID = 1L;
+
+    /**
+     * @param displayModel
+     * @param sortProperty
+     * @param propertyExpression
+     */
+ private NameLinkPropertyColumn(IModel displayModel, String sortProperty,
+        String propertyExpression) {
+      super(displayModel, sortProperty, propertyExpression);
+    }
+
+    @Override
+    public void onClick(Item item, String componentId, IModel model) {
+      IPerson person = (IPerson) model.getObject();
+      getRequestCycle().setResponsePage(new PersonDetailPage(person));
+    }
+  }
+
+  /**
+   *
+   */
+  private final class ProjectsPropertyColumn extends PropertyColumn {
+    private static final long serialVersionUID = 1L;
+
+    /**
+     * @param displayModel
+     * @param sortProperty
+     * @param propertyExpression
+     */
+ private ProjectsPropertyColumn(IModel displayModel, String sortProperty,
+        String propertyExpression) {
+      super(displayModel, sortProperty, propertyExpression);
+    }
+
+    @Override
+ public void populateItem(Item cellItem, String componentId, IModel model) {
+      Iterator<IProject> projects;
+      try {
+        projects = ((IPerson) model.getObject()).getProjects().iterator();
+        StringBuffer label = new StringBuffer();
+        while (projects.hasNext()) {
+          IProject project = projects.next();
+          label.append(project.getLabel());
+          if (projects.hasNext()) {
+            label.append(", ");
+          }
+        }
+        cellItem.add(new Label(componentId, label.toString()));
+      } catch (SimalRepositoryException e) {
+        cellItem.add(new Label(componentId, "ERROR"));
+      }
+    }
+  }
+
   /**
    * Form for filtering the people returned to a component.
    *
=======================================
--- /trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/panel/SourceRepositoriesPanel.java Tue Feb 16 05:15:45 2010 +++ /trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/panel/SourceRepositoriesPanel.java Tue Feb 16 10:06:22 2010
@@ -27,8 +27,6 @@
 import org.apache.wicket.markup.html.link.ExternalLink;
 import org.apache.wicket.markup.html.panel.Panel;
 import org.apache.wicket.markup.repeater.RepeatingView;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;

 import uk.ac.osswatch.simal.model.IDoapLocation;
 import uk.ac.osswatch.simal.model.IDoapRepository;
=======================================
--- /trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/report/ProjectsSummaryReportPage.java Mon Nov 16 14:40:58 2009 +++ /trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/report/ProjectsSummaryReportPage.java Tue Feb 16 10:06:22 2010
@@ -35,9 +35,12 @@
  * This page provides summary information about the projects supplied.
  */
 public class ProjectsSummaryReportPage extends BasePage {
-    private int numOfProjects;
-
-       public ProjectsSummaryReportPage() {
+
+  private static final long serialVersionUID = -4022201031446192100L;
+
+  private int numOfProjects;
+
+  public ProjectsSummaryReportPage() {
              try {
numOfProjects = UserApplication.getRepository().getAllProjects().size();
                          add(new Label("numOfProjects", 
Integer.toString(numOfProjects)));
@@ -58,40 +61,12 @@
        @SuppressWarnings("unchecked")
        private void populateReviewDetails() throws SimalRepositoryException {
int numOfProjectsWithReview = SimalRepositoryFactory.getProjectService().getProjectsWithReview().size();
-                 Link link = new Link("reviewedProjectsLink") {
-                       private static final long serialVersionUID = 1L;
-
-                       public void onClick() {
-                                 try {
- Set<IProject> projects = SimalRepositoryFactory.getProjectService().getProjectsWithReview();
-                                       ProjectBrowserPage page = new 
ProjectBrowserPage(projects);
-                                       setResponsePage(page);
-                               } catch (SimalRepositoryException e) {
-                                     UserReportableException error = new 
UserReportableException(
- "Unable to get projects with review", ProjectsSummaryReportPage.class, e);
-                                     setResponsePage(new 
ErrorReportPage(error));
-                               }
-                         }
-                 };
+                 Link link = new ReviewedProjectsLink("reviewedProjectsLink");
link.add(new Label("numOfProjectsWithReview", Integer.toString(numOfProjectsWithReview)));
                  add(link);

int numOfProjectsWithoutReview = numOfProjects - numOfProjectsWithReview;
-                 link = new Link("projectsToReviewLink") {
-                         private static final long serialVersionUID = 1L;
-
-                         public void onClick() {
-                                 try {
- Set<IProject> projects = SimalRepositoryFactory.getProjectService().getProjectsWithoutReview();
-                                       ProjectBrowserPage page = new 
ProjectBrowserPage(projects);
-                                       setResponsePage(page);
-                               } catch (SimalRepositoryException e) {
-                                     UserReportableException error = new 
UserReportableException(
- "Unable to get projects needing review", ProjectsSummaryReportPage.class, e);
-                                     setResponsePage(new 
ErrorReportPage(error));
-                               }
-                         }
-                 };
+                 link = new ProjectsToReviewLink("projectsToReviewLink");
                  add(link);
link.add(new Label("numOfProjectsWithoutReview", Integer.toString(numOfProjectsWithoutReview)));

@@ -102,40 +77,12 @@
        @SuppressWarnings("unchecked")
        private void populateRepositoryDetails() throws 
SimalRepositoryException {
int numOfProjectsWithRCS = SimalRepositoryFactory.getProjectService().getProjectsWithRCS().size();
-                 Link link = new Link("projectsWithRCSLink") {
-                               private static final long serialVersionUID = 1L;
-
-                         public void onClick() {
-                                 try {
- Set<IProject> projects = SimalRepositoryFactory.getProjectService().getProjectsWithRCS();
-                                       ProjectBrowserPage page = new 
ProjectBrowserPage(projects);
-                                       setResponsePage(page);
-                               } catch (SimalRepositoryException e) {
-                                     UserReportableException error = new 
UserReportableException(
- "Unable to get projects with RCS", ProjectsSummaryReportPage.class, e);
-                                     setResponsePage(new 
ErrorReportPage(error));
-                               }
-                         }
-                 };
+                 Link link = new ProjectsWithRCSLink("projectsWithRCSLink");
link.add(new Label("numOfProjectsWithRCS", Integer.toString(numOfProjectsWithRCS)));
                  add(link);

                  int numOfProjectsWithoutRCS = numOfProjects - 
numOfProjectsWithRCS;
-                 link = new Link("projectsWithoutRCSLink") {
-                               private static final long serialVersionUID = 1L;
-
-                         public void onClick() {
-                                 try {
- Set<IProject> projects = SimalRepositoryFactory.getProjectService().getProjectsWithoutRCS();
-                                       ProjectBrowserPage page = new 
ProjectBrowserPage(projects);
-                                       setResponsePage(page);
-                               } catch (SimalRepositoryException e) {
-                                     UserReportableException error = new 
UserReportableException(
- "Unable to get projects without RCS", ProjectsSummaryReportPage.class, e);
-                                     setResponsePage(new 
ErrorReportPage(error));
-                               }
-                         }
-                 };
+                 link = new ProjectsWithoutRCSLink("projectsWithoutRCSLink");
                  add(link);
link.add(new Label("numOfProjectsWithoutRCS", Integer.toString(numOfProjectsWithoutRCS)));

@@ -150,40 +97,12 @@
        @SuppressWarnings("unchecked")
        private void populateHomepageDetails() throws SimalRepositoryException {
int numOfProjectsWithHomepage = SimalRepositoryFactory.getProjectService().getProjectsWithHomepage().size();
-                 Link link = new Link("projectsWithHomepageLink") {
-                               private static final long serialVersionUID = 1L;
-
-                         public void onClick() {
-                                 try {
- Set<IProject> projects = SimalRepositoryFactory.getProjectService().getProjectsWithHomepage();
-                                       ProjectBrowserPage page = new 
ProjectBrowserPage(projects);
-                                       setResponsePage(page);
-                               } catch (SimalRepositoryException e) {
-                                     UserReportableException error = new 
UserReportableException(
- "Unable to get projects with homepage", ProjectsSummaryReportPage.class, e);
-                                     setResponsePage(new 
ErrorReportPage(error));
-                               }
-                         }
-                 };
+                 Link link = new 
ProjectsWithHomepageLink("projectsWithHomepageLink");
link.add(new Label("numOfProjectsWithHomepage", Integer.toString(numOfProjectsWithHomepage)));
                  add(link);

int numOfProjectsWithoutHomepage = numOfProjects - numOfProjectsWithHomepage;
-                 link = new Link("projectsWithoutHomepageLink") {
-                               private static final long serialVersionUID = 1L;
-
-                         public void onClick() {
-                                 try {
- Set<IProject> projects = SimalRepositoryFactory.getProjectService().getProjectsWithoutHomepage();
-                                       ProjectBrowserPage page = new 
ProjectBrowserPage(projects);
-                                       setResponsePage(page);
-                               } catch (SimalRepositoryException e) {
-                                     UserReportableException error = new 
UserReportableException(
- "Unable to get projects without homepage", ProjectsSummaryReportPage.class, e);
-                                     setResponsePage(new 
ErrorReportPage(error));
-                               }
-                         }
-                 };
+                 link = new 
ProjectsWithoutHomepageLink("projectsWithoutHomepageLink");
link.add(new Label("numOfProjectsWithoutHomepage", Integer.toString(numOfProjectsWithoutHomepage)));
                  add(link);

@@ -198,40 +117,12 @@
        @SuppressWarnings("unchecked")
private void populateMailingListDetails() throws SimalRepositoryException { int numOfProjectsWithMailingList = SimalRepositoryFactory.getProjectService().getProjectsWithMailingList().size();
-                 Link link = new Link("projectsWithMailingListLink") {
-                         private static final long serialVersionUID = 1L;
-
-                         public void onClick() {
-                                 try {
- Set<IProject> projects = SimalRepositoryFactory.getProjectService().getProjectsWithMailingList();
-                                       ProjectBrowserPage page = new 
ProjectBrowserPage(projects);
-                                       setResponsePage(page);
-                               } catch (SimalRepositoryException e) {
-                                     UserReportableException error = new 
UserReportableException(
- "Unable to get projects with mailing list", ProjectsSummaryReportPage.class, e);
-                                     setResponsePage(new 
ErrorReportPage(error));
-                               }
-                         }
-                 };
+ Link link = new ProjectsWithMailingListLink("projectsWithMailingListLink"); link.add(new Label("numOfProjectsWithMailingList", Integer.toString(numOfProjectsWithMailingList)));
                  add(link);

int numOfProjectsWithoutMailingList = numOfProjects - numOfProjectsWithMailingList;
-                 link = new Link("projectsWithoutMailingListLink") {
-                         private static final long serialVersionUID = 1L;
-
-                         public void onClick() {
-                                 try {
- Set<IProject> projects = SimalRepositoryFactory.getProjectService().getProjectsWithoutMailingList();
-                                       ProjectBrowserPage page = new 
ProjectBrowserPage(projects);
-                                       setResponsePage(page);
-                               } catch (SimalRepositoryException e) {
-                                     UserReportableException error = new 
UserReportableException(
- "Unable to get projects without mailing list", ProjectsSummaryReportPage.class, e);
-                                     setResponsePage(new 
ErrorReportPage(error));
-                               }
-                         }
-                 };
+ link = new ProjectsWithoutMailingListLink("projectsWithoutMailingListLink"); link.add(new Label("numOfProjectsWithoutMailingList", Integer.toString(numOfProjectsWithoutMailingList)));
                  add(link);

@@ -246,40 +137,12 @@
        @SuppressWarnings("unchecked")
        private void populateStaffDetails() throws SimalRepositoryException {
int numOfProjectsWithMaintainer = SimalRepositoryFactory.getProjectService().getProjectsWithMaintainer().size();
-                 Link link = new Link("projectsWithMaintainerLink") {
-                         private static final long serialVersionUID = 1L;
-
-                         public void onClick() {
-                                 try {
- Set<IProject> projects = SimalRepositoryFactory.getProjectService().getProjectsWithMaintainer();
-                                       ProjectBrowserPage page = new 
ProjectBrowserPage(projects);
-                                       setResponsePage(page);
-                               } catch (SimalRepositoryException e) {
-                                     UserReportableException error = new 
UserReportableException(
- "Unable to get projects with maintainer", ProjectsSummaryReportPage.class, e);
-                                     setResponsePage(new 
ErrorReportPage(error));
-                               }
-                         }
-                 };
+ Link link = new ProjectsWithMaintainerLink("projectsWithMaintainerLink"); link.add(new Label("numOfProjectsWithMaintainer", Integer.toString(numOfProjectsWithMaintainer)));
                  add(link);

int numOfProjectsWithoutMaintainer = numOfProjects - numOfProjectsWithMaintainer;
-                 link = new Link("projectsWithoutMaintainerLink") {
-                         private static final long serialVersionUID = 1L;
-
-                         public void onClick() {
-                                 try {
- Set<IProject> projects = SimalRepositoryFactory.getProjectService().getProjectsWithoutMaintainer();
-                                       ProjectBrowserPage page = new 
ProjectBrowserPage(projects);
-                                       setResponsePage(page);
-                               } catch (SimalRepositoryException e) {
-                                     UserReportableException error = new 
UserReportableException(
- "Unable to get projects without maintainer", ProjectsSummaryReportPage.class, e);
-                                     setResponsePage(new 
ErrorReportPage(error));
-                               }
-                         }
-                 };
+ link = new ProjectsWithoutMaintainerLink("projectsWithoutMaintainerLink"); link.add(new Label("numOfProjectsWithoutMaintainer", Integer.toString(numOfProjectsWithoutMaintainer)));
                  add(link);

@@ -294,40 +157,12 @@
        @SuppressWarnings("unchecked")
private void populateBugDatabaseDetails() throws SimalRepositoryException { int numOfProjectsWithBugDatabase = SimalRepositoryFactory.getProjectService().getProjectsWithBugDatabase().size();
-                 Link link = new Link("projectsWithBugDatabaseLink") {
-                         private static final long serialVersionUID = 1L;
-
-                         public void onClick() {
-                                 try {
- Set<IProject> projects = SimalRepositoryFactory.getProjectService().getProjectsWithBugDatabase();
-                                       ProjectBrowserPage page = new 
ProjectBrowserPage(projects);
-                                       setResponsePage(page);
-                               } catch (SimalRepositoryException e) {
-                                     UserReportableException error = new 
UserReportableException(
- "Unable to get projects with bug database", ProjectsSummaryReportPage.class, e);
-                                     setResponsePage(new 
ErrorReportPage(error));
-                               }
-                         }
-                 };
+ Link link = new ProjectsWithBugDatabaseLink("projectsWithBugDatabaseLink"); link.add(new Label("numOfProjectsWithBugDatabase", Integer.toString(numOfProjectsWithBugDatabase)));
                  add(link);

int numOfProjectsWithoutBugDatabase = numOfProjects - numOfProjectsWithBugDatabase;
-                 link = new Link("projectsWithoutBugDatabaseLink") {
-                         private static final long serialVersionUID = 1L;
-
-                         public void onClick() {
-                                 try {
- Set<IProject> projects = SimalRepositoryFactory.getProjectService().getProjectsWithoutBugDatabase();
-                                       ProjectBrowserPage page = new 
ProjectBrowserPage(projects);
-                                       setResponsePage(page);
-                               } catch (SimalRepositoryException e) {
-                                     UserReportableException error = new 
UserReportableException(
- "Unable to get projects without bug database", ProjectsSummaryReportPage.class, e);
-                                     setResponsePage(new 
ErrorReportPage(error));
-                               }
-                         }
-                 };
+ link = new ProjectsWithoutBugDatabaseLink("projectsWithoutBugDatabaseLink"); link.add(new Label("numOfProjectsWithoutBugDatabase", Integer.toString(numOfProjectsWithoutBugDatabase)));
                  add(link);

@@ -342,40 +177,12 @@
        @SuppressWarnings("unchecked")
        private void populateReleaseDetails() throws SimalRepositoryException {
int numOfProjectsWithRelease = SimalRepositoryFactory.getProjectService().getProjectsWithRelease().size();
-                 Link link = new Link("projectsWithReleasesLink") {
-                         private static final long serialVersionUID = 1L;
-
-                         public void onClick() {
-                                 try {
- Set<IProject> projects = SimalRepositoryFactory.getProjectService().getProjectsWithRelease();
-                                       ProjectBrowserPage page = new 
ProjectBrowserPage(projects);
-                                       setResponsePage(page);
-                               } catch (SimalRepositoryException e) {
-                                     UserReportableException error = new 
UserReportableException(
- "Unable to get projects without releases", ProjectsSummaryReportPage.class, e);
-                                     setResponsePage(new 
ErrorReportPage(error));
-                               }
-                         }
-                 };
+                 Link link = new 
ProjectsWithReleasesLink("projectsWithReleasesLink");
link.add(new Label("numOfProjectsWithRelease", Integer.toString(numOfProjectsWithRelease)));
                  add(link);

int numOfProjectsWithoutRelease = numOfProjects - numOfProjectsWithRelease;
-                 link = new Link("projectsWithoutReleasesLink") {
-                         private static final long serialVersionUID = 1L;
-
-                         public void onClick() {
-                                 try {
- Set<IProject> projects = SimalRepositoryFactory.getProjectService().getProjectsWithoutRelease();
-                                       ProjectBrowserPage page = new 
ProjectBrowserPage(projects);
-                                       setResponsePage(page);
-                               } catch (SimalRepositoryException e) {
-                                     UserReportableException error = new 
UserReportableException(
- "Unable to get projects without releases", ProjectsSummaryReportPage.class, e);
-                                     setResponsePage(new 
ErrorReportPage(error));
-                               }
-                         }
-                 };
+                 link = new 
ProjectsWithoutReleasesLink("projectsWithoutReleasesLink");
link.add(new Label("numOfProjectsWithoutRelease", Integer.toString(numOfProjectsWithoutRelease)));
                  add(link);

@@ -387,6 +194,398 @@
Double reviewedPercentOfProjectsWith = Double.valueOf(((double)numOfProjectsWithRelease / (double)numOfProjectsWithReview) * 100); add(new Label("reviewedPercentProjectsWithRelease", Math.round(reviewedPercentOfProjectsWith) + "%"));
        }
-
+
+  /**
+  *
+  */
+  private static final class ProjectsWithoutReleasesLink extends Link {
+    private static final long serialVersionUID = 1L;
+
+    /**
+     * @param id
+     */
+    private ProjectsWithoutReleasesLink(String id) {
+      super(id);
+    }
+
+    public void onClick() {
+      try {
+        Set<IProject> projects = SimalRepositoryFactory.getProjectService()
+            .getProjectsWithoutRelease();
+        ProjectBrowserPage page = new ProjectBrowserPage(projects);
+        setResponsePage(page);
+      } catch (SimalRepositoryException e) {
+        UserReportableException error = new UserReportableException(
+            "Unable to get projects without releases",
+            ProjectsSummaryReportPage.class, e);
+        setResponsePage(new ErrorReportPage(error));
+      }
+    }
+  }
+
+  /**
+  *
+  */
+  private static final class ProjectsWithReleasesLink extends Link {
+    private static final long serialVersionUID = 1L;
+
+    /**
+     * @param id
+     */
+    private ProjectsWithReleasesLink(String id) {
+      super(id);
+    }
+
+    public void onClick() {
+      try {
+        Set<IProject> projects = SimalRepositoryFactory.getProjectService()
+            .getProjectsWithRelease();
+        ProjectBrowserPage page = new ProjectBrowserPage(projects);
+        setResponsePage(page);
+      } catch (SimalRepositoryException e) {
+        UserReportableException error = new UserReportableException(
+            "Unable to get projects without releases",
+            ProjectsSummaryReportPage.class, e);
+        setResponsePage(new ErrorReportPage(error));
+      }
+    }
+  }
+
+  /**
+  *
+  */
+  private static final class ProjectsWithoutBugDatabaseLink extends Link {
+    private static final long serialVersionUID = 1L;
+
+    /**
+     * @param id
+     */
+    private ProjectsWithoutBugDatabaseLink(String id) {
+      super(id);
+    }
+
+    public void onClick() {
+      try {
+        Set<IProject> projects = SimalRepositoryFactory.getProjectService()
+            .getProjectsWithoutBugDatabase();
+        ProjectBrowserPage page = new ProjectBrowserPage(projects);
+        setResponsePage(page);
+      } catch (SimalRepositoryException e) {
+        UserReportableException error = new UserReportableException(
+            "Unable to get projects without bug database",
+            ProjectsSummaryReportPage.class, e);
+        setResponsePage(new ErrorReportPage(error));
+      }
+    }
+  }
+
+  /**
+  *
+  */
+  private static final class ProjectsWithBugDatabaseLink extends Link {
+    private static final long serialVersionUID = 1L;
+
+    /**
+     * @param id
+     */
+    private ProjectsWithBugDatabaseLink(String id) {
+      super(id);
+    }
+
+    public void onClick() {
+      try {
+        Set<IProject> projects = SimalRepositoryFactory.getProjectService()
+            .getProjectsWithBugDatabase();
+        ProjectBrowserPage page = new ProjectBrowserPage(projects);
+        setResponsePage(page);
+      } catch (SimalRepositoryException e) {
+        UserReportableException error = new UserReportableException(
+            "Unable to get projects with bug database",
+            ProjectsSummaryReportPage.class, e);
+        setResponsePage(new ErrorReportPage(error));
+      }
+    }
+  }
+
+  /**
+  *
+  */
+  private static final class ProjectsWithoutMaintainerLink extends Link {
+    private static final long serialVersionUID = 1L;
+
+    /**
+     * @param id
+     */
+    private ProjectsWithoutMaintainerLink(String id) {
+      super(id);
+    }
+
+    public void onClick() {
+      try {
+        Set<IProject> projects = SimalRepositoryFactory.getProjectService()
+            .getProjectsWithoutMaintainer();
+        ProjectBrowserPage page = new ProjectBrowserPage(projects);
+        setResponsePage(page);
+      } catch (SimalRepositoryException e) {
+        UserReportableException error = new UserReportableException(
+            "Unable to get projects without maintainer",
+            ProjectsSummaryReportPage.class, e);
+        setResponsePage(new ErrorReportPage(error));
+      }
+    }
+  }
+
+  /**
+  *
+  */
+  private static final class ProjectsWithMaintainerLink extends Link {
+    private static final long serialVersionUID = 1L;
+
+    /**
+     * @param id
+     */
+    private ProjectsWithMaintainerLink(String id) {
+      super(id);
+    }
+
+    public void onClick() {
+      try {
+        Set<IProject> projects = SimalRepositoryFactory.getProjectService()
+            .getProjectsWithMaintainer();
+        ProjectBrowserPage page = new ProjectBrowserPage(projects);
+        setResponsePage(page);
+      } catch (SimalRepositoryException e) {
+        UserReportableException error = new UserReportableException(
+            "Unable to get projects with maintainer",
+            ProjectsSummaryReportPage.class, e);
+        setResponsePage(new ErrorReportPage(error));
+      }
+    }
+  }
+
+  /**
+  *
+  */
+  private static final class ProjectsWithoutMailingListLink extends Link {
+    private static final long serialVersionUID = 1L;
+
+    /**
+     * @param id
+     */
+    private ProjectsWithoutMailingListLink(String id) {
+      super(id);
+    }
+
+    public void onClick() {
+      try {
+        Set<IProject> projects = SimalRepositoryFactory.getProjectService()
+            .getProjectsWithoutMailingList();
+        ProjectBrowserPage page = new ProjectBrowserPage(projects);
+        setResponsePage(page);
+      } catch (SimalRepositoryException e) {
+        UserReportableException error = new UserReportableException(
+            "Unable to get projects without mailing list",
+            ProjectsSummaryReportPage.class, e);
+        setResponsePage(new ErrorReportPage(error));
+      }
+    }
+  }
+
+  /**
+  *
+  */
+  private static final class ProjectsWithMailingListLink extends Link {
+    private static final long serialVersionUID = 1L;
+
+    /**
+     * @param id
+     */
+    private ProjectsWithMailingListLink(String id) {
+      super(id);
+    }
+
+    public void onClick() {
+      try {
+        Set<IProject> projects = SimalRepositoryFactory.getProjectService()
+            .getProjectsWithMailingList();
+        ProjectBrowserPage page = new ProjectBrowserPage(projects);
+        setResponsePage(page);
+      } catch (SimalRepositoryException e) {
+        UserReportableException error = new UserReportableException(
+            "Unable to get projects with mailing list",
+            ProjectsSummaryReportPage.class, e);
+        setResponsePage(new ErrorReportPage(error));
+      }
+    }
+  }
+
+  /**
+  *
+  */
+  private static final class ProjectsWithoutHomepageLink extends Link {
+    private static final long serialVersionUID = 1L;
+
+    /**
+     * @param id
+     */
+    private ProjectsWithoutHomepageLink(String id) {
+      super(id);
+    }
+
+    public void onClick() {
+      try {
+        Set<IProject> projects = SimalRepositoryFactory.getProjectService()
+            .getProjectsWithoutHomepage();
+        ProjectBrowserPage page = new ProjectBrowserPage(projects);
+        setResponsePage(page);
+      } catch (SimalRepositoryException e) {
+        UserReportableException error = new UserReportableException(
+            "Unable to get projects without homepage",
+            ProjectsSummaryReportPage.class, e);
+        setResponsePage(new ErrorReportPage(error));
+      }
+    }
+  }
+
+  /**
+  *
+  */
+  private static final class ProjectsWithHomepageLink extends Link {
+    private static final long serialVersionUID = 1L;
+
+    /**
+     * @param id
+     */
+    private ProjectsWithHomepageLink(String id) {
+      super(id);
+    }
+
+    public void onClick() {
+      try {
+        Set<IProject> projects = SimalRepositoryFactory.getProjectService()
+            .getProjectsWithHomepage();
+        ProjectBrowserPage page = new ProjectBrowserPage(projects);
+        setResponsePage(page);
+      } catch (SimalRepositoryException e) {
+        UserReportableException error = new UserReportableException(
+            "Unable to get projects with homepage",
+            ProjectsSummaryReportPage.class, e);
+        setResponsePage(new ErrorReportPage(error));
+      }
+    }
+  }
+
+  /**
+  *
+  */
+  private static final class ProjectsWithoutRCSLink extends Link {
+    private static final long serialVersionUID = 1L;
+
+    /**
+     * @param id
+     */
+    private ProjectsWithoutRCSLink(String id) {
+      super(id);
+    }
+
+    public void onClick() {
+      try {
+        Set<IProject> projects = SimalRepositoryFactory.getProjectService()
+            .getProjectsWithoutRCS();
+        ProjectBrowserPage page = new ProjectBrowserPage(projects);
+        setResponsePage(page);
+      } catch (SimalRepositoryException e) {
+        UserReportableException error = new UserReportableException(
+            "Unable to get projects without RCS",
+            ProjectsSummaryReportPage.class, e);
+        setResponsePage(new ErrorReportPage(error));
+      }
+    }
+  }
+
+  /**
+  *
+  */
+  private static final class ProjectsWithRCSLink extends Link {
+    private static final long serialVersionUID = 1L;
+
+    /**
+     * @param id
+     */
+    private ProjectsWithRCSLink(String id) {
+      super(id);
+    }
+
+    public void onClick() {
+      try {
+        Set<IProject> projects = SimalRepositoryFactory.getProjectService()
+            .getProjectsWithRCS();
+        ProjectBrowserPage page = new ProjectBrowserPage(projects);
+        setResponsePage(page);
+      } catch (SimalRepositoryException e) {
+        UserReportableException error = new UserReportableException(
+ "Unable to get projects with RCS", ProjectsSummaryReportPage.class,
+            e);
+        setResponsePage(new ErrorReportPage(error));
+      }
+    }
+  }
+
+  /**
+  *
+  */
+  private static final class ProjectsToReviewLink extends Link {
+    private static final long serialVersionUID = 1L;
+
+    /**
+     * @param id
+     */
+    private ProjectsToReviewLink(String id) {
+      super(id);
+    }
+
+    public void onClick() {
+      try {
+        Set<IProject> projects = SimalRepositoryFactory.getProjectService()
+            .getProjectsWithoutReview();
+        ProjectBrowserPage page = new ProjectBrowserPage(projects);
+        setResponsePage(page);
+      } catch (SimalRepositoryException e) {
+        UserReportableException error = new UserReportableException(
+            "Unable to get projects needing review",
+            ProjectsSummaryReportPage.class, e);
+        setResponsePage(new ErrorReportPage(error));
+      }
+    }
+  }
+
+  /**
+  *
+  */
+  private static final class ReviewedProjectsLink extends Link {
+    private static final long serialVersionUID = 1L;
+
+    /**
+     * @param id
+     */
+    private ReviewedProjectsLink(String id) {
+      super(id);
+    }
+
+    public void onClick() {
+      try {
+        Set<IProject> projects = SimalRepositoryFactory.getProjectService()
+            .getProjectsWithReview();
+        ProjectBrowserPage page = new ProjectBrowserPage(projects);
+        setResponsePage(page);
+      } catch (SimalRepositoryException e) {
+        UserReportableException error = new UserReportableException(
+            "Unable to get projects with review",
+            ProjectsSummaryReportPage.class, e);
+        setResponsePage(new ErrorReportPage(error));
+      }
+    }
+  }
+
 }

=======================================
--- /trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/widgets/InstantiateWidgetPage.java Tue Feb 16 01:53:18 2010 +++ /trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/widgets/InstantiateWidgetPage.java Tue Feb 16 10:06:22 2010
@@ -18,7 +18,6 @@
  */

 import java.io.IOException;
-import java.io.UnsupportedEncodingException;

 import org.apache.wicket.markup.html.basic.Label;
 import org.apache.wicket.markup.html.link.Link;
@@ -35,11 +34,11 @@
  */
 public class InstantiateWidgetPage extends BasePage {

-       /**
+  private static final long serialVersionUID = -2075240720179434503L;
+
+  /**
         * Attempt to instantiate a widget using a wookie server.
         *
-        * @param parameters
-        * @throws UnsupportedEncodingException
         */
        public InstantiateWidgetPage(Widget widget) {
       Instance instance;
@@ -76,8 +75,10 @@
           *          the widget we want to instantiate with this page
           * @return
           */
-         public static Link getLink(final String id, final Widget widget) {
+         public static Link getLink(final String id, final Widget widget) {
           return new Link(id) {
+            private static final long serialVersionUID = 4984984523L;
+
                   public void onClick(){
                           setResponsePage(new InstantiateWidgetPage(widget));
              }
=======================================
--- /trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/widgets/WookieWidgetPanel.java Tue Feb 16 05:15:45 2010 +++ /trunk/uk.ac.osswatch.simal.web/src/main/java/uk/ac/osswatch/simal/wicket/widgets/WookieWidgetPanel.java Tue Feb 16 10:06:22 2010
@@ -20,8 +20,6 @@
 import org.apache.wicket.behavior.SimpleAttributeModifier;
 import org.apache.wicket.markup.html.WebMarkupContainer;
 import org.apache.wicket.markup.html.panel.Panel;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;

 /**
* A panel to display a Wookie Widget. See http://incubator.apache.org/wookie

--
You received this message because you are subscribed to the Google Groups "Simal 
Commits" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/simal-commits?hl=en.

Reply via email to