Hmmm. Wasn't me. But in any case, I have made the change you suggest in the latest version (rev 1628) on the trunk. Thanks for sleuthing it.
Regards, Larry ----- Original Message ---- From: culver <[EMAIL PROTECTED]> To: SIMILE Widgets <[email protected]> Sent: Thursday, October 23, 2008 8:51:53 AM Subject: Re: Event painter highlight feature not working with original or detailed painter Disregard my last post. I resolved the issue. In the latest version of Timeline, someone had commented out (temporarily I assume) a line of code in original-painter.js although it probably should be enabled for most users. The line of code was in the Timeline.OriginalEventPainter.prototype._createHighlightDiv function call, and the line is div.style.background = color; Users should check their local Timeline webapp and will want to modify this line of code to enable highlighting events. Later, Hunt On Oct 22, 8:09 pm, culver <[EMAIL PROTECTED]> wrote: > I am not sure if this is the same problem that I am having. > > In my tests using the setup controls, highlighting works only on the > overview layout but not for the original or detailed painters. The > filter works in all three. I reviewed the js files, reviewed the > groups discussions, and the wiki but haven't found any obvious errors. > > Is any one else having this problem, or it it just me? Is there some > global control that has it disabled? > > Need help, > > Hunt > > On Sep 22, 12:56 pm, LarryK <[EMAIL PROTECTED]> wrote: > > > Hi Jcorreia, > > > Thank you for your posts. > > > I think there are two separate issues, yes? > > 1) Overview event painter ignores color > > attribute.http://code.google.com/p/simile-widgets/issues/detail?id=16 > > > Status: someone commented out the code at some point. Reason unknown. > > > 2) Highlighting colors, when filtering, don't work > > I filed issue 19:http://code.google.com/p/simile-widgets/issues/detail?id=19 > > > Unfortunately, I don't have time right now to work either issue. If > > you'd like to work on the sw, that'd be great. > > -- For both issues, the first thing would be to look backin time using > > svn browsing and look at the comments from the person who changed the > > sw to remove the features. My guess is that they were not working > > right due to other changes in the code base. So the relevant event > > attributes are now ignored. eg the fixes for the issues are probably > > more than simply uncommenting the source. > > > You can either obtain check in permission, or just send in patches to > > the mailing list and others (including me) will test and then checkin > > the software. > > > Thanks, > > > Larry > > > On Sep 22, 8:07 am, jcorreia <[EMAIL PROTECTED]> wrote: > > > > The file I was refering is > > > \timeline\timeline\trunk\src\webapp\api\scripts\themes.js > > > > you have > > > highlightColors: [ > > > // "#FFFF00", > > > // "#FFC000", > > > // "#FF0000", > > > // "#0000FF" > > > > If you leave it this way, thehighlightcolors of filters.js won´t > > > appear. If you uncoment they will appear, but they are broken and not > > > working. > > > Highlightcolorsfilteris not working as you can check in jfk example. > > > > Thanks, > > > Jcorreia > > > > On 18 Set, 15:11, LarryK <[EMAIL PROTECTED]> wrote: > > > > > Hi, > > > > > On Sep 18, 4:47 am, jcorreia <[EMAIL PROTECTED]> wrote: > > > > > > Another thing that I´ve noticed is that someone commented the > > > > > 'hightlightcolors' from css and js files. With this move my > > > > > filters.js is not rendering thefilterby colors option.. > > > > > Can you check this also ? > > > > > Thanks > > > > > Which css file? > > > > I just looked > > > > inhttp://simile-widgets.googlecode.com/svn/timeline/trunk/src/webapp/ap... --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "SIMILE Widgets" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/simile-widgets?hl=en -~----------~----~----~----~------~----~------~--~---
