Hi Larry, That looks like a bug on line 101. I think few people have used JSON so that's probably why nobody has found it before.
I think you're right that a new attribute should be supported, and durationEvent sounds good to me. David LarryK wrote: > Hi, > > As I've been working my way through implementation of my production > Timeline app, I was quite puzzled by the definition the isDuration > event attribute. As you can see from the test example, > http://simile-widgets.googlecode.com/svn/timeline/trunk/src/webapp/examples/test_example/test.html > > if isDuration is true, then a "instance" icon is shown. If isDuration > is false or missing, then only the event's tape is shown. Further > digging has revealed that isDuration for json is the opposite of > isDuration for XML and SPARQL data formats! > > {{{ > // See > http://code.google.com/p/simile-widgets/source/browse/timeline/tags/2.2.0/src/webapp/api/scripts/sources.js > > // line 48, loadXML format: > instant: node.getAttribute("isDuration") != > "true", > > // line 101 loadJSON format: > instant: event.isDuration || false, > > // line 188 loadSPARQL format: > instant: bindings["isDuration"] != "true", > }}} > > I checked the repository and it has been like this for over a year. > Of course, it would not be a good idea to change JSON's isDuration > definition now since that would break existing implementations. But > the current situation is pretty wrong from the documentation and "it > just doesn't seem to make sense" points of view. > > My plan: > * add a new event attribute of "durationEvent" which will be defined > the same as XML's "isDuration" attribute. > * Still support durationEvent exactly the same as it is now. Add > comments to the source so future maintainers won't remove it. > > I've filled issue 33. > > ==>> Comments? > > Thanks, > > Larry > > > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "SIMILE Widgets" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/simile-widgets?hl=en -~----------~----~----~----~------~----~------~--~---
