Hi Niels, Thank you for the patches! Please do commit them after having tested them with the existing examples. More below...
On 10/11/2009 2:12 PM, Niels Mayer wrote: > These fixes enable access to underlying functionality in Exhibit's > widgetry via exhibit's way of passing parameters. So it's not untested > new functionality, just bugfix/enhancement to access existing working > functionality. > Specifically, ex:bubbleOrientation is now honored by timeline and > table views (actually any view using showItemInPopup()), and > ex:bubbleHeight is honored, rather than being ignored. Timeline gains > ex:topBandMultiple and ex:bottomBandMultiple settings to reduce > clutter in the legends (and scrolling performance when many need to be > drawn). > > http://nielsmayer.com/npm-fix-exhibit-bubble-enhance-timeline.js (overrides > to functions, and comments on changes, see below) > http://nielsmayer.com/npm-fix-exhibit-trunk.patch (patch against > current exhibit trunk) > http://nielsmayer.com/npm-fix-timeline-231.patch (patch against > timeline 2.3.1 -- note the patched functions are unchanged in trunk so > this patch can apply to trunk.). > > Question: were I to commit the timeline fixes to trunk, they won't be > seen because Exhibit uses the 2.3.1 Timeline. Is there a separate > "branch" for 2.3.1 to allow the same fixes to be applied both to trunk > timeline and Exhibit's? No, there's no such branch. However, when you use Exhibit, you can explicitly include Timeline before including Exhibit, and Exhibit won't try to include Timeline again. That way, you can decide which version of Timeline to use. Of course, you have to be sure they are compatible. > Seems like it would be almost as much work to add a 2.3.2 timeline > containing the patches and point exhibit at that, as it would to just > upgrade exhibit to use the (already existing) "trunk" timeline. What > is the status of moving Exhibit to the "trunk" timeline? Also, what is > the process for re-generating and uploading the "bundle" and > "bundle-debug" versions of timeline and exhibit once changes are made > to the source? Exhibit shouldn't point to trunk Timeline, as then Exhibit would break when trunk Timeline is in the midst of development. The process for releasing Timeline involves - running ant in the timeline directory to generate bundle files - updating RELEASE_NOTES.txt and CHANGES.txt in the timeline directory - testing and committing timeline - within the hour, trunk.simile-widgets.org/timeline/ should get updated with the trunk version. test it, too. - tagging timeline (into timeline/tags) - svn co the api-site project - updating svn:externals in the timeline directory to link to the new tag - I think we have a cron job that should update api.simile-widgets.org within the hour. If not, log onto simile-widgets.org and update it manually. David --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "SIMILE Widgets" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/simile-widgets?hl=en -~----------~----~----~----~------~----~------~--~---
