Revision: 1831
Author: olavmrk
Date: Thu Oct  8 05:06:35 2009
Log: saml2/idp/SSOService: Log warning if the AssertionConsumerService in  
the request is invalid.
http://code.google.com/p/simplesamlphp/source/detail?r=1831

Modified:
  /trunk/www/saml2/idp/SSOService.php

=======================================
--- /trunk/www/saml2/idp/SSOService.php Mon Oct  5 03:53:43 2009
+++ /trunk/www/saml2/idp/SSOService.php Thu Oct  8 05:06:35 2009
@@ -149,8 +149,16 @@
                $spmetadata = $metadata->getMetaData($spentityid, 
'saml20-sp-remote');

                $consumerURL = $authnrequest->getAssertionConsumerServiceURL();
-               $consumerArray =  
SimpleSAML_Utilities::arrayize($spmetadata['AssertionConsumerService']);
-               if (($consumerURL != NULL) && (array_search($consumerURL,  
$consumerArray) !== FALSE)) $requestcache['ConsumerURL'] = $consumerURL;
+               if ($consumerURL !== NULL) {
+                       $consumerArray =  
SimpleSAML_Utilities::arrayize($spmetadata['AssertionConsumerService']);
+                       if (in_array($consumerURL, $consumerArray, TRUE)) {
+                               $requestcache['ConsumerURL'] = $consumerURL;
+                       } else {
+                               SimpleSAML_Logger::warning('Authentication 
request from ' .  
var_export($spentityid, TRUE) .
+                                       ' contains invalid 
AssertionConsumerService URL. Was ' .
+                                       var_export($consumerURL, TRUE) . ', 
could be ' .  
var_export($consumerArray, TRUE) . '.');
+                       }
+               }

                $IDPList = $authnrequest->getIDPList();


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"simpleSAMLphp commits" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/simplesamlphp-commits?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to