Revision: 3029
Author:   olavmrk
Date:     Mon Feb  6 23:43:21 2012
Log:      Fix a couple of pass-by-referece errors.

Since pass-by-reference has been removed in PHP 5.4, it should no
longer be used. Both of these places probably used it by mistake,
so removing it should be safe.

Thanks to Thijs Kinkhorst for fixing this!
http://code.google.com/p/simplesamlphp/source/detail?r=3029

Modified:
 /trunk/modules/InfoCard/lib/STS.php
 /trunk/modules/saml2debug/www/debug.php

=======================================
--- /trunk/modules/InfoCard/lib/STS.php Fri Feb 13 08:37:42 2009
+++ /trunk/modules/InfoCard/lib/STS.php Mon Feb  6 23:43:21 2012
@@ -151,7 +151,7 @@

                $signature = '';
$privkey = openssl_pkey_get_private(file_get_contents($ICconfig['sts_key']));
-               openssl_sign($canonicalbuf, &$signature, $privkey);
+               openssl_sign($canonicalbuf, $signature, $privkey);
                openssl_free_key($privkey);
                $infocard_signature = base64_encode($signature);

=======================================
--- /trunk/modules/saml2debug/www/debug.php     Wed May 19 02:24:53 2010
+++ /trunk/modules/saml2debug/www/debug.php     Mon Feb  6 23:43:21 2012
@@ -11,7 +11,7 @@
        if (!empty($url)) $val = $url;

        $arr = array();
-       $query = parse_str($val, &$arr);
+       $query = parse_str($val, $arr);

        #echo('<pre>');print_r($arr);

--
You received this message because you are subscribed to the Google Groups 
"simpleSAMLphp commits" group.
To post to this group, send email to simplesamlphp-commits@googlegroups.com.
To unsubscribe from this group, send email to 
simplesamlphp-commits+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/simplesamlphp-commits?hl=en.

Reply via email to