Revision: 3228
Author: olavmrk
Date: Wed Mar 13 00:07:35 2013
Log: SAMLParser: Fix incorrect assertion & documentation in
parseElement().
The parseElement()-function actually accepts a
SAML2_XML_md_EntityDescriptor object, not a DOMElement.
Thanks to François Kooman for reporting this bug and supplying a patch!
http://code.google.com/p/simplesamlphp/source/detail?r=3228
Modified:
/trunk/lib/SimpleSAML/Metadata/SAMLParser.php
=======================================
--- /trunk/lib/SimpleSAML/Metadata/SAMLParser.php Mon Oct 15 06:21:13 2012
+++ /trunk/lib/SimpleSAML/Metadata/SAMLParser.php Wed Mar 13 00:07:35 2013
@@ -223,13 +223,13 @@
/**
- * This function parses a DOMElement which represents a EntityDescriptor
element.
+ * This function parses a SAML2_XML_md_EntityDescriptor object which
represents a EntityDescriptor element.
*
- * @param $entityElement A DOMElement which represents a
EntityDescriptor element.
+ * @param $entityElement A SAML2_XML_md_EntityDescriptor object which
represents a EntityDescriptor element.
* @return An instance of this class with the metadata loaded.
*/
public static function parseElement($entityElement) {
- assert('$entityElement instanceof DOMElement');
+ assert('$entityElement instanceof
SAML2_XML_md_EntityDescriptor');
return new SimpleSAML_Metadata_SAMLParser($entityElement, NULL);
}
--
You received this message because you are subscribed to the Google Groups
"simpleSAMLphp commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to simplesamlphp-commits+unsubscr...@googlegroups.com.
To post to this group, send email to simplesamlphp-commits@googlegroups.com.
Visit this group at http://groups.google.com/group/simplesamlphp-commits?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
