Checked-in. Thanks a lot, very nice feature.
Olivier. F. Tarek Rogers wrote: >> Tarek, >> >> This looks like a nice patch, which will make the scenario language much >> more extensible. >> >> I just have two suggestions: >> 1. Would it be possible to compile the regular expression when reading >> the XML file? This would eliminate some per-message overhead, and improve >> performance at high loads. I am not sure if this would be difficult to >> implement or not. >> > > Good suggestion. Rather than compiling at parse time, I made a change to > only perform the compile once, for the first call, and then store the > compiled expr in the message class, so I believe it amounts to the same thing. > > New diff attached (this replaces the previous diff) > > >> 2. This could also make sense for the reply codes as well as requests. >> For example, instead of using <recv reply="100" /> to match a 100 reply, >> the regular expression <recv reply="1.." /> could match any provisional >> response. Conversely, reply="[2-6].." would match any final reply. I am >> not 100% sure what I would use this for yet, but it seems like a logical >> extension. >> > > The issue here is that recv reply is given an atol() treatment, where recv > request is stored as a string, so there would be a bit more surgery to keep > recv reply as string and convert the compare operations over, and I suspect > I'd need to store the successful match off for return_code matching... I'll > keep it in mind, however, next time I find myself with some time. > > >> Charles >> >> > > -- Olivier HP OpenCall Software http://www.hp.com/go/opencall/ ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Sipp-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sipp-users
