Bugs item #1677896, was opened at 2007-03-10 15:20
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=637564&aid=1677896&group_id=104305

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Laszlo BORTEL (bortel)
Assigned to: Nobody/Anonymous (nobody)
Summary: Authentication problem

Initial Comment:
When using keyword [authentication] in a scenario file, without explicitly 
giving username and password, the authentication fails, because the 
authentication algorithm uses empty username and password, instead of the ones 
given on the sipp command line.
The problem is detected in 1.1 RC8, Windows/cygwin, but present in all versions 
since 3GPP AKA authentication was introduced. The problem is caused by the 
following code cut out from call.cpp. The code copies variables 'service' and 
'auth_password' first to my_auth_user and my_auth_pass, then effectively 
overwrites them with memcpy later.
Solution: memset function calls should be reordered before strcpy.

        auth_marker = src;
        auth_marker_len = strchr(src, ']') - src;
        strcpy(my_auth_user, service);
        strcpy(my_auth_pass, auth_password);
        /* Look for optional username and password parameters */
        /* add aka_OP, aka_AMF, aka_K */
        key = getKeywordParam(src, "username=", my_auth_user);
        memset(my_auth_pass,0,KEYWORD_SIZE);
        key = getKeywordParam(src, "password=", my_auth_pass);
        memset(my_aka_OP,0,KEYWORD_SIZE);
        key = getKeywordParam(src, "aka_OP=", my_aka_OP);
        memset(my_aka_AMF,0,KEYWORD_SIZE);
        key = getKeywordParam(src, "aka_AMF=", my_aka_AMF);
        memset(my_aka_K,0,KEYWORD_SIZE);
        key = getKeywordParam(src, "aka_K=", my_aka_K);
        if (my_aka_K[0]==0){
            memcpy(my_aka_K,my_auth_pass,16);
            my_aka_K[16]=0;
        }

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=637564&aid=1677896&group_id=104305

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Sipp-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sipp-users

Reply via email to