Hello all,
I'm sending this mail to the sipp user list as apparently there is not
much life on sipp-devel.
OK, maybe my mistake, I just checked
http://sipp.sourceforge.net/doc/reference.html telling this sipp-users
list is the right one, so here is the mail again anyhow:
> From: VAN DIEST Marcus (ITN/NIS)
> Sent: 13 February 2008 09:54
> To: '[EMAIL PROTECTED]'
> Cc: '[EMAIL PROTECTED]'
> Subject: patch on sipp 3.0 for missing authentication in 401/407
>
> Hello all,
>
> a bug in our system revealed that when sipp receives a 401 without an
> Authentication line in the header (recv auth=true), the program quits
> with the message "Couldn't find 'Proxy-Authenticate' or
> 'WWW-Authenticate' in 401 or 407!". This way, the load on the system
> is of course reduced and unstable as the sipp executables disappear on
> the first error.
>
> Below you can find a patch that will keep the error messages, but
> continues the sipp program execution (sending out the next message
> with the [authentication ...] line removed as no auth info was found
> in the 401). This way the system load is stable, the errors can still
> be found in the xxx_errors.log.
>
> --------------------------------------------
> diff -bruN sipp-3.0.src/call.cpp sipp-3.0.new/call.cpp
> --- sipp-3.0.src/call.cpp 2007-11-06 11:18:07.000000000 +0100
> +++ sipp-3.0.new/call.cpp 2008-02-11 14:37:28.000000000 +0100
> @@ -2296,7 +2296,9 @@
> method, uri, body, dialog_authentication,
> auth_comp->comp_param.auth_param.aka_OP,
> auth_comp->comp_param.auth_param.aka_AMF,
> auth_comp->comp_param.auth_param.aka_K,
> result + authlen) == 0) {
> - ERROR_P1("%s", result + authlen);
> + WARNING_P1("%s", result + authlen);
> + result[0]='\0';/* clear error message */
> + auth_marker_len+=2;/* move marker behind end of line */
> }
> authlen = strlen(result);
>
> @@ -2998,7 +3000,7 @@
> strcpy(auth, get_header_content(msg,
> (char*)"WWW-Authenticate:"));
> }
> if (auth[0] == 0) {
> - ERROR("Couldn't find 'Proxy-Authenticate' or
> 'WWW-Authenticate' in 401 or 407!");
> + WARNING("Couldn't find 'Proxy-Authenticate' or
> 'WWW-Authenticate' in 401 or 407!");
> }
>
> dialog_authentication = (char *) realloc(dialog_authentication,
> strlen(auth) + 2);
> ----------------------------------------------------------
>
>
> Best regards,
>
> MarcVD
>
> P.S. can you give a little feedback when treated
>
> (-: from Marc VAN DIEST (BELGACOM) ;-)
>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Sipp-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sipp-users
