Bugs item #1954305, was opened at 2008-04-29 12:53
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=637564&aid=1954305&group_id=104305

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Kevin McAllister (mcallist)
Assigned to: Nobody/Anonymous (nobody)
Summary: 3.1 get_remote_port_media throws away part of port number

Initial Comment:
I found that when using the pcapplay to send a ulaw stream that if my asterisk 
server told it to send media to 13134, sipp was sending media to 1313.  

Looking at the source, it looks like the pointer math is just off in 
get_remote_port_media() in call.cpp. 

--- sipp.svn/call.cpp   2008-04-09 10:50:37.000000000 -0400
+++ sipp.svn.patched/call.cpp   2008-04-29 12:52:20.000000000 -0400
@@ -192,7 +192,7 @@
       /* m=audio not found */
       return 0;
     }
-    begin += strlen(pattern) - 1;
+    begin += strlen(pattern);
     end = strstr(begin, "\r\n");
     if (!end)
       ERROR("get_remote_port_media: no CRLF found");


if you leave the -1 in there begin ends up pointing at the blank space after 
the pattern, so for m=audio 13134 it is pointing at the space between the o and 
1, and your strncpy will grab 5 characters starting with the blank space 
omitting the 4.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=637564&aid=1954305&group_id=104305

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Sipp-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sipp-users

Reply via email to