I had another look at this and the nextLabels map already has a strdup (leaking
memory of course). So a crude fix to the problem is to change:
line 739 of scenario.cpp to:
labelMap[strdup(ptr)] = length;
and line 1639 of scenario.cpp to:
ontimeoutLabels[length] = strdup(ptr);
and put a note on the TODO list about the leaking memory. I have tested it and
it does fix Sumeet's issue. The memory loss is one off not continuous.
Peter
From: plh...@hotmail.com
To: cpwri...@us.ibm.com
Date: Wed, 13 Jan 2010 22:48:18 +0000
CC: sipp-users@lists.sourceforge.net
Subject: Re: [Sipp-users] label, next and ontimeout broken in 3.1
Charles,
Care is needed to delete the space that strdup allocates (from malloc so free()
is needed).
I'm assuming that since the label maps are only needed for the scenario
compilation, they are freed before the main phase. (I can see code that frees
the maps.) Already I see that strdup is used with txnRevMap and the map freed
without freeing the strdup allocations.
Peter
Subject: Re: [Sipp-users] label, next and ontimeout broken in 3.1
To: plh...@hotmail.com
CC: sipp-users@lists.sourceforge.net; sumeet_bhard...@persistent.co.in
From: cpwri...@us.ibm.com
Date: Wed, 13 Jan 2010 16:13:55 -0500
I think the best answer would be to strdup the return from xp_get_value, as the
named labels are far friendlier when writing any complex scenario that uses
more than a handful of labels.
Charles
Peter Higginson ---01/13/2010 16:09:56---
Peter Higginson <plh...@hotmail.com>
01/13/2010 16:08
To
<sumeet_bhard...@persistent.co.in>, sipp_users
<sipp-users@lists.sourceforge.net>
cc
Subject
[Sipp-users] label, next and ontimeout broken in 3.1
The C routine xp_get_value returns a pointer to a static buffer from which a
value is normally extracted, or in a few cases a string is copied to a new
buffer.
The new label code takes this pointer and uses it as the str part of an
int_str_map. So it's just junk - it points to whatever last used the
xp_get_value routine and it's a serious bug. It impacts all labels so I have
changed the title of this message.
Unless there is some magic way to get map to copy the elements (I don't know
one), I can see a hard way (make an explicit copy of the strings) or an easy
way (restrict the labels to integers) to fix this.
Changing both the str_int_map and the int_str_map to int_int_map would be
fairly simple to do. It would give you arbitrary integers as labels and keep
the error checking advantage of the new code and allow large numbers of labels.
Integers are the only things documented so I doubt many scenarios have
non-numeric labels.
The next step is upto the maintainers.
The only thing I can suggest to Sumeet is to use version 3.0 which allows
labels 1-99 only but has the old working code.
Peter
From: plh...@hotmail.com
To: sumeet_bhard...@persistent.co.in; sipp-users@lists.sourceforge.net
Date: Wed, 13 Jan 2010 18:11:19 +0000
Subject: Re: [Sipp-users] FW: Help- ontimeout is not working
Being snowed-in in Southern England (it is just so infrequent that we do not
prepare for it) I am having a look at this in a bit more depth. The report so
far is:
It looks like the forward reference resolver is broken. So backward references
work and all forward references go to the last defined label. I have a trap in
scenario::apply_labels which shows this happening.
------------------------------------------------------------------------------
The history is that when I wrote the label and next stuff I avoided having a
resolver pass by limiting the labels to 1-n. (n was 9 initially - now 99.) My
logic was that scenarios should be simple with few labels and the array
required was smaller than the code for a resolver pass. Someone later wrote a
resolver pass to get more flexibility and error checking - I'm fine with this
but it means I'm now looking at code that is new to me.
------------------------------------------------------------------------------
If you simplify your scenario to only use one label or only use backward
references then it will work. (However I suspect that is hard to do.)
Peter Higginson
From: sumeet_bhard...@persistent.co.in
To: sipp-users@lists.sourceforge.net
Date: Tue, 12 Jan 2010 15:21:44 +0530
Subject: [Sipp-users] FW: Help- ontimeout is not working
Please reply if anyone knows about this.
Thanks
-Sumeet
From: Sumeet Bhardwaj
Sent: Monday, January 11, 2010 6:05 PM
To: 'Peter Higginson'; dushyant.dha...@rancoretech.com
Cc: sipp_users
Subject: RE: [Sipp-users] Help- ontimeout is not working
Hello All,
I am using sip 3.1 version.
Only using uac xml
And command for the same is :
sipp -sf Sample.xml <ip>:<port> -inf <input csv file> -r 1 -rp 1s -nr -trace_msg
Thanks
-Sumeet
From: Peter Higginson [mailto:plh...@hotmail.com]
Sent: Monday, January 11, 2010 5:00 PM
To: dushyant.dha...@rancoretech.com; Sumeet Bhardwaj
Cc: sipp_users
Subject: RE: [Sipp-users] Help- ontimeout is not working
Also the exact version you were using....
What you have to watch is what "state" you are in. (When all else fails put a
trace on the state.) I'm retired now and not actively using SIPP but my memory
is that if you are expecting a 100 then you are probably still in the transmit
state and doing re-transmits that will eventually time out themselves.
Peter
Date: Mon, 11 Jan 2010 16:43:10 +0530
From: dushyant.dha...@rancoretech.com
To: sumeet_bhard...@persistent.co.in
CC: plh...@hotmail.com; sipp-users@lists.sourceforge.net
Subject: Re: [Sipp-users] Help- ontimeout is not working
Can u send the following -
1. xml for uac.
2. xml for uas.
3. command for uac
4. command for uas
Dushyant
Sumeet Bhardwaj wrote:
Still not Jumping L
Thanks
-Sumeet
From: Dushyant Dhalia [mailto:dushyant.dha...@rancoretech.com]
Sent: Monday, January 11, 2010 4:21 PM
To: Sumeet Bhardwaj
Cc: Peter Higginson; sipp_users
Subject: Re: [Sipp-users] Help- ontimeout is not working
Try this and use -nr option.
Sumeet Bhardwaj wrote:
Still not jumping to label 2 L
Thanks
-Sumeet
From: Dushyant Dhalia [mailto:dushyant.dha...@rancoretech.com]
Sent: Monday, January 11, 2010 4:13 PM
To: Sumeet Bhardwaj
Cc: Peter Higginson; sipp_users
Subject: Re: [Sipp-users] Help- ontimeout is not working
use timeout="20000" instead of 20 if u want 20 seconds.
Dushyant
Sumeet Bhardwaj wrote:
Hello Dushyant,
When it doesn’t receive 100 Trying response, it is not jumping to label 2.
Please help me.
Thanks
-Sumeet
From: Dushyant Dhalia [mailto:dushyant.dha...@rancoretech.com]
Sent: Monday, January 11, 2010 3:58 PM
To: Sumeet Bhardwaj
Cc: Peter Higginson; sipp_users
Subject: Re: [Sipp-users] Help- ontimeout is not working
Try this.
Dushyant P S Dhalia
Sumeet Bhardwaj wrote:
Hello All,
Please find attached xml file and let me know what’s goes wrong.
Thanks
-Sumeet
From: Dushyant Dhalia [mailto:dushyant.dha...@rancoretech.com]
Sent: Thursday, January 07, 2010 3:34 PM
To: Sumeet Bhardwaj
Cc: Peter Higginson; sipp_users
Subject: Re: [Sipp-users] Help- ontimeout is not working
Can you send the xml script?
Sumeet Bhardwaj wrote:
Hello Peter,
I have tried your suggestion, but still it’s not working. I have also tried
after removing the optional part still it’s not jumping to the label.
Please provide any other suggestion.
Thanks
-Sumeet
From: Peter Higginson [mailto:plh...@hotmail.com]
Sent: Thursday, January 07, 2010 3:00 PM
To: Sumeet Bhardwaj; sipp_users
Subject: RE: [Sipp-users] Help- ontimeout is not working
The most likely cause is:
If you use ontimeout with optional="true" you need to make sure that the
ontimeout is in every member of the optional receive block.
Peter
From: sumeet_bhard...@persistent.co.in
To: sipp-users@lists.sourceforge.net
Date: Thu, 7 Jan 2010 12:31:27 +0530
Subject: [Sipp-users] Help- ontimeout is not working
Hello All,
I am using sipp 3.1 version, I am using ontimeout event to jump at defined
label, but sipp is not jumping at that label.
Please find below sample script in which it is suppose to jump at label 14 if
it doesn’t receive 100 trying response in 20s, But unfortunately it is not
working. Please help me out.
<recv response="100" timeout="20000" ontimeout="14" optional="true"
response_txn="invite">
</recv>
<Others recv tags to jump at lable 13>
<label id="14"/>
<send>
<![CDATA[
CANCEL sip:1...@atlanta.com;user=phone SIP/2.0
[last_Via:]
[last_From:]
[last_To:]
[last_Call-ID:]
Max-Forwards: 68
CSeq: [cseq] CANCEL
Contact: <sip:s...@[local_ip]:[local_port];transport=udp>
Content-Length: 0
]]>
</send>
<recv response="200" optional="false" rtd="true" crlf="true" timeout="20000"
ontimeout="15"/>
<recv response="487" optional="false" rtd="true" crlf="true" next="15"
timeout="20000" ontimeout="15"/>
<label id="13"/>
<send ack_txn="invite">
<![CDATA[
ACK sip:1...@atlanta.com;user=phone SIP/2.0
[last_Via:]
[last_From:]
[last_To:]
[last_Call-ID:]
Max-Forwards: 68
CSeq: [cseq] ACK
Contact: <sip:s...@[local_ip]:[local_port];transport=udp>
Content-Length: 0
]]>
</send>
<label id="15"/>
Thanks
-Sumeet
DISCLAIMER ========== This e-mail may contain privileged and confidential
information which is the property of Persistent Systems Ltd. It is intended
only for the use of the individual or entity to which it is addressed. If you
are not the intended recipient, you are not authorized to read, retain, copy,
print, distribute or use this message. If you have received this communication
in error, please notify the sender and delete all copies of this message.
Persistent Systems Ltd. does not accept any liability for virus infected mails.
New! Receive and respond to mail from other email accounts from within Hotmail
Find out how.
DISCLAIMER ========== This e-mail may contain privileged and confidential
information which is the property of Persistent Systems Ltd. It is intended
only for the use of the individual or entity to which it is addressed. If you
are not the intended recipient, you are not authorized to read, retain, copy,
print, distribute or use this message. If you have received this communication
in error, please notify the sender and delete all copies of this message.
Persistent Systems Ltd. does not accept any liability for virus infected mails.
--
"When work is a pleasure, life is a joy! When work is duty, life is slavery."
DISCLAIMER ========== This e-mail may contain privileged and confidential
information which is the property of Persistent Systems Ltd. It is intended
only for the use of the individual or entity to which it is addressed. If you
are not the intended recipient, you are not authorized to read, retain, copy,
print, distribute or use this message. If you have received this communication
in error, please notify the sender and delete all copies of this message.
Persistent Systems Ltd. does not accept any liability for virus infected mails.
--
"When work is a pleasure, life is a joy! When work is duty, life is slavery."
DISCLAIMER ========== This e-mail may contain privileged and confidential
information which is the property of Persistent Systems Ltd. It is intended
only for the use of the individual or entity to which it is addressed. If you
are not the intended recipient, you are not authorized to read, retain, copy,
print, distribute or use this message. If you have received this communication
in error, please notify the sender and delete all copies of this message.
Persistent Systems Ltd. does not accept any liability for virus infected mails.
--
"When work is a pleasure, life is a joy! When work is duty, life is slavery."
DISCLAIMER ========== This e-mail may contain privileged and confidential
information which is the property of Persistent Systems Ltd. It is intended
only for the use of the individual or entity to which it is addressed. If you
are not the intended recipient, you are not authorized to read, retain, copy,
print, distribute or use this message. If you have received this communication
in error, please notify the sender and delete all copies of this message.
Persistent Systems Ltd. does not accept any liability for virus infected mails.
--
"When work is a pleasure, life is a joy! When work is duty, life is slavery."
DISCLAIMER ========== This e-mail may contain privileged and confidential
information which is the property of Persistent Systems Ltd. It is intended
only for the use of the individual or entity to which it is addressed. If you
are not the intended recipient, you are not authorized to read, retain, copy,
print, distribute or use this message. If you have received this communication
in error, please notify the sender and delete all copies of this message.
Persistent Systems Ltd. does not accept any liability for virus infected mails.
--
"When work is a pleasure, life is a joy! When work is duty, life is slavery."
Got a cool Hotmail story? Tell us now
DISCLAIMER ========== This e-mail may contain privileged and confidential
information which is the property of Persistent Systems Ltd. It is intended
only for the use of the individual or entity to which it is addressed. If you
are not the intended recipient, you are not authorized to read, retain, copy,
print, distribute or use this message. If you have received this communication
in error, please notify the sender and delete all copies of this message.
Persistent Systems Ltd. does not accept any liability for virus infected mails.
Do you have a story that started on Hotmail? Tell us now
Do you have a story that started on Hotmail? Tell us
now------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
Sipp-users mailing list
Sipp-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sipp-users
Got a cool Hotmail story? Tell us now
_________________________________________________________________
Send us your Hotmail stories and be featured in our newsletter
http://clk.atdmt.com/UKM/go/195013117/direct/01/------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Sipp-users mailing list
Sipp-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sipp-users
