shruthi.j wrote:
> Hi ,
> 
> I have completed working on XCF-2786 by following the below steps :
> 
>     * Moved polycom support to polycom folder under plugins.
>     * Added build.xml.
>     * Added Makefile.am and Makefile.in.
>     * Ran all the ant commands (ant , ant style , ant test, ant
>       precommit ) successfully.
> 
> 
> After this when  I was creating  patch , the moved files in
> plugins/polycom are not getting added to the patch. When I was trying to
> detect what is happening I understood that svn move is scheduled with
> commit.
> 
> So can any body tell me the method to create patch for moved file using
> " svn mv " or shell I commit changes instead of sending the patch for
> this issue.
> 
> 
> Thanks,
> Shruthi
> 

Attach the patch (svn diff) and attach new plugins/polycom zipped. I can
clean it up before committing.

I am actually OK with you just committing the changes but we need to wait
for OK from Huijun since he is coordinating Polycom plugin.

Thanks for implementing this!

Huijun - what do you think. Can we move it now?
D.


PS.
git handles file moves and renames and generates patches that can be
applied with standard set of tools

_______________________________________________
sipx-dev mailing list
[email protected]
List Archive: http://list.sipfoundry.org/archive/sipx-dev
Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev

Reply via email to