Dale wrote: > Subject: Re: [sipX-dev] XECS-1599 - Correct use of poll() on > sockets/pipes > > On Mon, 2008-09-29 at 15:24 -0400, Raymond Dans wrote: > > I've been looking at XECS-1599 which states that the SipClient and > > OsSocket::isReadyToRead() are incorrectly using poll() when > reading in > > data from a socket. > > > > After examining the code for these two areas, I cannot > figure out why > > this would still be the case after the fix for "XECS-1583 - > Imdb Table > > Replication sometimes times out with large table". With the fix > > (which is used by SipClient), we're now properly emptying > the socket > > buffer after each poll() so any call to poll will correctly > identify > > new data which we haven't yet read. > > > > Does anyone know if XECS-1599 is still a valid issue or can > I close it > > off. > > Has anyone looked at the call of poll() at line 550 of SipClient.cpp? > If that poll() reports that the pipe contains data, the > current code does not read the pipe until it gets to the end > of its contents. > Didn't look at that one. There are 2 file descriptors in the SipClient.cpp. I only looked at the one that was for a socket. I'll check the other which is using a queue.
Thanks for your help. _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
