On Fri, 2008-10-24 at 15:13 -0400, Arjun Nair wrote: > > Perhaps this code should be replaced by the authorization code used in > > the auth proxy function? > > I am not sure I understand what you mean. The SipRouter authorization > code uses a similar algorithm (at least from an initial glance).
You've already addressed part of the difference between RLS and SipRouter in your version of Oct 26. I looked at the code in SipRouter::isAuthenticated, and there is one useful difference: it uses a different version of CredentialDB::getCredential. In particular, it calls getCredential with the (auth) user name and realm, rather than the identity and realm. This is an improvement, because that this point in the code, we have to construct the auth-identity, whereas the auth-user has been directly extracted by HttpRequest::getDigestAuthorizationData. I was wondering if you could revise the change to the RLS to use this version of getCredential. It would allow you to remove the construction of 'fromNameAddr' (in the Oct 26 version) a/k/a 'identity' (in the Oct 27 version). Dale _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
