On Wed, 2008-11-26 at 18:40 +0200, Mircea Carasel wrote:
> Hi,
>
> I attached to XCF-2924 a test patch:
>
>
> http://track.sipfoundry.org/secure/attachment/16790/0001-TEST-PATCH-XCF-2924-dns-ip-test-script.patch
>
> Please review and let me know if the approach taken is good.
> The script in discussion gets saved in /bin directory (because I think
> that can be run by users too)
I would strongly prefer to see each test as a separate script rather
than as arguments to a common script. Putting them in ${bindir} is fine
- name them sipx-test-* (please do not add any .sh or other extension).
While this may mean some small amount of duplication, it is cleaner and
simpler to maintain, and we can refactor most common code into the
sipx-utils library.
I don't know what the potential is for using it right now, but I want to
preserve the text output that the existing tests print. The current
sipXconfig tests are (IMHO) pretty much useless precisely because they
don't tell you anything more than pass/fail.
The test description you provided is not really correct:
Verify that the DNS server(s) supplied by the DHCP server can
properly resolve the name and IP values.
That test has nothing to do with anything the DHCP server does or not
does not provide. It checks to see if the SIP domain configured for the
proxy is correctly configured to route to the current system (note that
this test will fail if it is being run on the local system and that
system does not have a proxy).
_______________________________________________
sipx-dev mailing list
[email protected]
List Archive: http://list.sipfoundry.org/archive/sipx-dev
Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
