Dale Worley wrote: > I've started looking at Arjun's patch. So far so good. I've attached a > revised version to XECS-1929, called dialog_match_fix2.diff. The > revisions are mostly changing call-by-name parameters into > call-by-reference parameters, and adding 'const' modifiers. The methods > in question use parameter objects in a purely read-only way, and there's > no reason not to take advantage of it.
Ah yes, of course.. > > Also, I've marked some of the modified methods "needs comment" -- they > were undocumented in the .h files when Arjun started, and I'm hoping > that his hard-won knowledge of what they do will allow him to easily > write comments for them. (That way I don't have to deduce what they're > supposed to do myself!) I will add in the comments and submit the updated diff. Thanks! Arjun _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
