<taking to dev-list> <Background: discussion about the patch for XECS-845 Emergency Call Notification>
> -----Original Message----- > From: Worley, Dale (BL60:9D30) > Sent: Wednesday, January 21, 2009 4:24 PM > To: Beeton, Carolyn (CAR:9D60) > Subject: RE: emergencyrules.xml > > On Wed, 2009-01-21 at 08:53 -0500, Beeton, Carolyn (CAR:9D60) wrote: > > It was suggested that the best way to determine that an Emergency > > number had been dialled was to implement an Auth Plugin to check > > for emergency numbers. Although emergency dial plan rules are saved > > in other xml files (e.g. authrules.xml), there is no way of > > distinguishing them as Emergency (we can't rely on the rule name or > > description as that is customer-editable). I therefore decided that > > the easiest way to have an independent plugin was to create a new xml > > file containing only the emergency rules. It is slightly different from > > the authrules as I wanted to be able to parse the rule name as well as > > the description (other rules files for some reason saved the name as a > > comment only). This rules file does not change the content of the > > authrules.xml in any way; nor does it change the authentication > > processing of emergency numbers which still happens in other plugins. > > The only purpose of the emergency notification auth plugin is to > > recognize and generate a notification (currently an alarm) if someone > > dials an emergency number. > > The alternative would be to share the authrules.xml file, adding a > > <ruleType> tag which would allow Emergency rules to be identified. > > I preferred not to do this as it would require changing the > > parsing in other auth-plugins. > > It seems from EmergencyRules.java that emergencyrules.xml is > generated specifying the namespace > 'http://www.sipfoundry.org/sipX/schema/xml/urlmap-00-00', and > that is the .xsd file into which you added the new ruleType > element. But urlmap is for mappingrules, not authrules, so > it seems that emergencyrules.xml is a variant of > mappingrules.xml not of authrules.xml. > My mistake. That comes because my first attempt at this many months ago was a redirector, not an auth-plugin. It should be a urlauth-00-00. (Although as stated below, I'll get rid of it entirely and just share authrules.xml). > In regard to using authrules.xml to drive both the > authorization process and the emergency notification, adding > an element to it shouldn't be a problem, as anything that > parses an XML file should ignore elements and attributes that > it does not understand. (And presumably it would be quick > enough to examine the relevant code to verify that.) > > I'm adverse to creating a new file to communicate information > from sipXconfig to the proxy, with its own schema, etc., and > yet containing information that is mostly duplicated from > another such file. All that has to be maintained. It seems > that it would be much simpler to add an element or attribute > to the authrules schema. > > Dale > Sounds reasonable. Does keeping the notification separate from the EnforceAuthRules plugin itself still seem correct? Carolyn _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
