Hi Dale, The patch has changes for the SipSubscribeClient::endSubscription() method.
In the JIRA you note that removeState() fails for early dialogs, since they aren't in mSubscriptions. 1. The previous code would do a mpDialogMgr->getEarlyDialogHandleFor() when removeState() fails. Seems to make sense, because removeState() fails for early dialogs. The patch changes this to call mpDialogMgr->getEstablishedDialogHandleFor() when removeState() fails. How does that work? Wouldn't removeState() have succeed for the dialog if was established? 2. Do we need any changes in SipSubscribeClient::endAllSubscriptions()? It is called from ResourceListServer.cpp, though only during shutdown. Thanks. -Paul [email protected]
_______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
