Since the new XECS-845 patch contains all the architectural improvements
I can think of, there are only a few nits left where I think the code
could be made clearer:
In UrlMapping::getUserMatchContainerMatchingRequestURI, I think this
formulation would be easier to understand:
+ //if ruleType is constrained, check for match
+ if ( ruleType != NULL )
+ {
+ const TiXmlNode* typeNode =
pHostMatchNode->FirstChild("ruleType");
+ if (!typeNode)
+ {
+ continue;
+ }
+ UtlString currentRuleType = typeNode->FirstChild()->Value();
+ if ( currentRuleType != ruleType )
+ {
+ continue;
+ }
+ }
In EmergencyNotify::readConfig:
OsPath defaultPath =
SipXecsService::Path(SipXecsService::ConfigurationDirType,
DEFAULT_EMERG_RULES_FILENAME);
fileName = defaultPath;
could be simplified to:
fileName =
SipXecsService::Path(SipXecsService::ConfigurationDirType,
DEFAULT_EMERG_RULES_FILENAME);
Clearly you copied this from EnforceAuthRules::readConfig, but I think
that one should be changed also.
In EmergencyNotify::authorizeAndModify:
AuthResult result = CONTINUE;
...
return result;
could be simplified to:
...
return CONTINUE;
Dale
_______________________________________________
sipx-dev mailing list
[email protected]
List Archive: http://list.sipfoundry.org/archive/sipx-dev
Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
