Damian wrote: > Paul Mossman wrote: > > Hi all, > > > > Working on XCF-3575 I had a need for a field that would > accept only IP > > addresses. Damian referred me to the "ipaddr" setting > type, which is > > now described in the Wiki: > > > > > > > _http://sipx-wiki.calivia.com/index.php/SipX_ConfigServer_settings.xml > > _ > > > > The problem is that the field still accepts non-IP values. I'm not > > sure if this was the intent or not, since the code that does the > > validation is proving elusive to me. > > > > You can observe this behaviour in existing phone profiles. > Create a > > Nortel IP Phone 1230 profile, navigate into Lines -> X -> > Registration > > and look at the "Registrar Address" field. The default > value will be > > a domain name, which is appropriate. Yet the "registrarAddress" > > setting type in nortel12x0 line.xml is "ipaddr". > > > > Anyway its to late to use this for XCF-3575, so I've just beefed up > > the help text to say that domain names won't work. > > > > But, can anyone confirm the intended behaviour? If the current > > behaviour is indeed intended, then what benefit does > "ipaddr" provide > > over and above the default "string"? > > > > > Looks like it 'ipaddr' type was never properly implemented. > It should have a validIPv4 validator attached. I think it's > now mapped to 'string' type at the moment. > > There is an issue on that: > http://track.sipfoundry.org/browse/XCF-2695
Thanks Damian. I added a comment to XCF-2695: When this is fixed, each current use of "ipaddr" will need to be checked. There is at least one setting for which a domain name value is perfectly acceptable. Actually, the default value is a domain name. (Create a Nortel IP Phone 1230 profile, navigate into Lines -> X -> Registration and look at the "Registrar Address" field.) -Paul [email protected] _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
