Dale Worley wrote: > Currently, the code assumes that the Freeswitch executable is > at /usr/local/freeswitch/bin/freeswitch, and does no checking > whatsoever. Based on feedback I've gotten, I've implemented a new > strategy: > > ./configure checks where the Freeswitch executable is located. > Currently, it only checks /usr/local/freeswtich/bin/freeswitch, but > alternative locations can be given with the --with-freeswitch switch. > > If Freeswitch is found, FREESWITCH_PREFIX is set accordingly. If > Freeswitch is not found, a warning is given, and FREESWITCH_PREFIX is > set to /usr/local/freeswitch. > > At start-up time, "freeswitch.sh --configtest" tests whether > FREESWITCH_PREFIX/bin/freeswitch is present and executable. If not, it > prints an error and returns a non-zero status. > > The attached patch implements this strategy, along with a few minor > fixes. I'd like feedback. > > Dale > >
I don't think FREESWITCH_PREFIX is actually used any more in sipXconfig. I did some quick grepping around: [sipXconfig]$ git grep FREESWITCH_PREFIX build.properties.in:freeswitch.prefix.d...@freeswitch_prefix@ we set 'freeswitch.prefix.dir' in build.properties [sipXconfig]$ git grep freeswitch.prefix.dir build.properties.in:freeswitch.prefix.d...@freeswitch_prefix@ neoconf/build.xml: <replacefilter token="@freeswitch.prefix.dir@" property="freeswitch.prefix.dir" /> neoconf/etc/sipxconfig.properties.in:[email protected]@ we use it to set sysdir.freeswitch in sipxconfig.properties [sipXconfig]$ git grep sysdir.freeswitch neoconf/etc/sipxconfig.properties.in:[email protected]@ neoconf/src/org/sipfoundry/sipxconfig/test/TestUtil.java: sysProps.setProperty("sysdir.freeswitch", outputDirectory + "/freeswitch"); and we only use it in TestUtil to generate test version of sipxconfig.properties... Looks to me like it can be safely removed from sipXconfig entirely. D. _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
