Scott Lawrence <scott.lawrence <at> nortel.com> writes: > > On Wed, 2009-07-29 at 16:50 -0400, Arjun Nair wrote: > > Scott Lawrence wrote: > > > On Wed, 2009-07-29 at 16:13 -0400, Arjun Nair wrote: > > >> So here's what happens now: sipx-swadmin.py looks for the sipxcommons > > >> rpm in the rpm db and then outputs the result in the format > > >> > > >> print sipxPackage[0].name + " " + sipxPackage[0].ver + "-" + sipxPackage[0].release > > >> > > >> to a file. > > >> > > >> SipXconfig, then GETs this file from sipXsupervisor and parses the > > >> text inside, getting the version and the release number. This was the > > >> parsing I was referring to. The problem is, with the SCS, the file has > > >> an extra line at the top -- Loading "fastestmirror" plugin .. And, > > >> sipXconfig does not account for this line, when parsing this file. So > > >> one option is, we could have sipXconfig explicitly make sure that this > > >> line is not there. > > > > > > If there's a 'Loading "fastestmirror"' embedded in a version string > > > somewhere, then that's just a bug - fix the generation of the version > > > string. > > > > > > > Sure, it's easy enough to fix. However, this method does seem a bit > > error prone to me (esp. over different the flavors of OSs we run on).. > > Anything over the STDOUT of sipx-swadmin.py is output to the file, so > > todays "Loading fastestmirror plugin" maybe tommrow's "Some other > > random message over STDOUT". Hence, I was proposing a different > > implementation, that looked relatively safer to me. Having said that, > > if the general consensus is that the risk is negligible, and its not > > worth changing the implementation over, then I will go ahead and just > > fix the bug.. > > If one of the functions of sipx-swadmin.py is to output the version > string in a usable way, then it just needs to be implemented so that > works... > > The bottom line is that the Software Update screen does RPM updates, and if sipx was not installed by RPMs, then the screen should say that, clearly (and probably localizably - i.e. not just putting up a string from a file): "sipx RPMs are not installed and will not be updated".
How we get there: I think it would be better if sipx-swadmin.py could figure out that RPMs are not installed and put a sensible message in the file. Failing that, sipXconfig should figure it out based on what is in the file. Probably an element of both is required. Carolyn _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev sipXecs IP PBX -- http://www.sipfoundry.org/
