Damian Krzeminski 提到:
> Steve wrote:
>   
>> Hello Damian
>>
>> Finally I build sipx develop environment successful on FC10.
>>
>> Testing with G-Tek phone and works.
>>
>> I have add some settings to line.xml & phone.xml
>> Fix line_index bug in config.vm
>>
>> Please take look
>>
>> Thank you
>>
>> Steve
>>
>>     
>
>
> Great news.
> Thanks for fixing config.vm
> I can committing the initial version as soon as you sing contributors
> agreement:
>
> http://www.sipfoundry.org/contributor-agreement.html
>   
Thank you, I will sign contributors agreement
> Some comments to your changes:
> Adding new parameters is great. But please remember about updating:
>
> gtek/test/org/sipfoundry/sipxconfig/phone/gtek/expected-config
> I cannot take your changes if tests fail.
>
> Try not to hard code any specific values like time zone or NTP server
> address.
> You should get the time zone info from DeviceDefaults.getTimeZone and
> NTP server address from DeviceDefaults.getNtpServer.
> Check out LG Nortel plugin to see how it works.
>   
OK, fixed

Add GtekPhoneDefaults.java
> Similarly adding support for sipXconfig speed dials is probably better
> then displaying UI for each button in the plug-in.
> I added some notes here on how to do that.
> http://sipx-wiki.calivia.com/index.php/Adding_support_for_managed_phones#Advanced_Features
> D.
>
>   
OK, fixed

Please see attach files

Thank you

Steve


CONFIDENTIALITY NOTICE:
This e-mail, including attachments, may include confidential and/or proprietary 
information, and may be used only by the person or entity to which it is 
addressed. If the reader of this e-mail is not the intended recipient or his or 
her authorized agent, the reader is hereby notified that any dissemination, 
distribution or copying of this e-mail is prohibited. If you have received this 
e-mail in error, please notify the sender by replying to this message and 
delete this e-mail immediately.

Attachment: GtekPhone.tar.gz
Description: GNU Zip compressed data

_______________________________________________
sipx-dev mailing list sipx-dev@list.sipfoundry.org
List Archive: http://list.sipfoundry.org/archive/sipx-dev
Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
sipXecs IP PBX -- http://www.sipfoundry.org/

Reply via email to