David Saint wrote:
>> I am merging 4.0 -> main
>>
>> This one confused me:
>> http://code.sipfoundry.org/changelog/sipXecs/?cs=16006
>>
>> The comment says:
>>
>> Delete this line:
>>   <param name="comfort-noise-level" value="1400"/> It isn't 
>> used anymore.
>> Change this:
>>   <param name="comfort-noise" value="true"/> to this:
>>   <param name="comfort-noise" value="1400"/>
>>
>>
>> The code however does this:
>>
>> -                addParam(profile, "confort-noise", "true");
>> +                addParam(profile, "comfort-noise", ZERO);
>>
>>
>> Effectively changing 'comfort-noise' to 0 (not to 1400).
>>
>>   <param name="comfort-noise" value="0"/>
>>
>>
>> Which one is correct? The comment or the code?
>> D.
>>
> 
> Looking at the 1.0.4 freeswitch code:
>   src/mod/applications/mod_conference/mod_conference.c
> it looks like a value of "0" will force it to use the default value
> "1400" 
> so they will both do the same thing.
> 
> Dave

Thanks. I'll go ahead and commit it.
D.

_______________________________________________
sipx-dev mailing list [email protected]
List Archive: http://list.sipfoundry.org/archive/sipx-dev
Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
sipXecs IP PBX -- http://www.sipfoundry.org/

Reply via email to