On Tue, 2009-09-15 at 07:49 -0400, Carolyn Beeton wrote:
> The SAA sometimes needs to reject an incoming NOTIFY for a client
> subscription (e.g. when two sets simultaneously attempt to "seize" the
> same appearance (line key)).
> 
> Initially I did this by implementing a MessageObserver, but it would
> be much cleaner if I could configure the SipSubscribeClient to not
> automatically OK NOTIFYs and instead allow the application to do it.
> Would it be all right to add a boolean parameter to
> SipSubscribeClient::addSubscription to set auto-OK on or off for the
> subscription?  SipSubscribeClient::handleNotifyRequest would do
> everything it does now, except send an OK response only if the bool
> autoOK was set to true.

Sounds like a good idea.

Even better would be to define a public method within SipSubscribeClient
that gets passed the NOTIFY and returns a boolean for whether or not to
send an OK.  An application like yours that needs to make a real
decision just subclasses SipSubscribeClient and overrides that method
(the base class could just always return true).


_______________________________________________
sipx-dev mailing list [email protected]
List Archive: http://list.sipfoundry.org/archive/sipx-dev
Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
sipXecs IP PBX -- http://www.sipfoundry.org/

Reply via email to