Mircea Mihai Carasel wrote:
> Hi,
>
> With regard to XX-6527: http://track.sipfoundry.org/browse/XX-6527 - I
> would like to make sure that I understood what we need here.
>
> First of all, I noticed that PlayVoicemailService.java (Tapestry
> service) it is not used anymore. This was used for reading voicemails
> (hearing voicemails). Now this was replaced by a voicemail URL (served
> by a REST call) call combined with <audio tag:
>
> public String getVoicemailLink() {
> Voicemail voicemail = getVoicemail();
> String voicemailLink =
> String.format("/sipxconfig/rest/my/voicemail/%s/%s",
> voicemail.getFolderId(),
> voicemail.getMessageId());
> ....
> ( I searched through previous ManageVoicemail.html/ManageVoicemail.java
> checkins to make sure.)
>
> 1. PlayVoicemailService.java can now be safely deleted (not used elsewhere)
> 2. MailboxOperation.java can now be safely deleted (not used elsewhere)
> - move voicemail tasks are now handled by MoveVoicemailAction.java
> 3. Unused methods from ManageVoicemail.java:
> a) public void activateExternalPage(Object[] parameters, IRequestCycle
> cycle)
> b) public PlayVoicemailService.Info getPlayVoicemailInfo() - should be
> deleted
>
> What we need to do:
>
> Before, PlayVoicemailService.java was in charge with mark read
> voicemails (MailboxManager.markRead method)
> Right now, we need to call markRead somehow from within
> ManageVoicemail's <audio tag, or when the voicemail message finished
> playing.
MailboxManager.markRead() method is called when you do a GET for a particular
voicemail (in VoicemailResourceDownload.represent()). This method would work
fine when we are not using the audio tags, i.e. when we use the download link,
which will just do a GET for the vm in question, automatically marking the
mailbox as read. With the audio tags however, we could try disable auto
buffering, so that we don't do a GET for the vm file until the user clicks the
play button. I am not sure if it will work though, because the player might
still try and load some of the media to get and display the duration
information.
>
> markRead (empty right now) shoud make a REST call (as Woof suggests) to
> mark that voicemail heard(read):
> PUT: /mailbox/{mailbox}/message/{message id}/
>
> In order to get status (heard/read)/unheared:
> GET: /mailbox/{mailbox}/message/{message id}/heard
> Before this REST option, sipXconfig was supposed to verify xx-00.sta
> zero length file existence.
> if xx-00.sta was present, then that message was unheard(unread). This
> mechanism is not used anymore and have to be removed from sipXconfig.
>
> Regarding UI - a nice icon should be shown in the ManageVoicemail table
> (column: Subject) - as it is now, when voicemail is not read and a
> different one when it is read (I guess we do not need extra UI, or
> something more complicated).
>
Arjun
_______________________________________________
sipx-dev mailing list [email protected]
List Archive: http://list.sipfoundry.org/archive/sipx-dev
Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
sipXecs IP PBX -- http://www.sipfoundry.org/
