George Niculae wrote: > Hi All, > > I've opened issue XX-6825 - the following scenario breaks unique ImId > rule: - user 201 without ImId is created - it will get the default ImId > 201 - user 202 is created and ImId set with 201 This will result in user > 201 and user 202 having the same ImId - 201. > > This is due to the fact that the default ImId is calculated using > ImAccount but is not saved as user ImId. > > A simple solution would be to make User.getImId to retrieve > ImAccount.getImId value if AddressBookEntry.getImId is empty - and to > have the default ImId saved in the database as well (checking if unique > will resume to existing mechanism, by selecting count of users with same > ImId account)
I am against saving calculated IM ID in DB. That's going to be misleading: sipXconfig should always know if user configured IM ID or if it was calculated automatically. If you overwrite the IM field we lose this. Also it might not be easy to implement: saving to DB is not possible in read only sessions that we use in some places (when generating/exporting information). > > A new column can be added in address_book_entry table if we need to > store also the default ImId value. > > Please let me know if you see any drawback on this, > > Thanks, George > > > It seems to me it would be simpler if we checked IM ID against the list of user aliases - and vice versa. And since we are going to do that we can actually add it as a user alias when generating aliases dataset (it's XX-6447) D. _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev sipXecs IP PBX -- http://www.sipfoundry.org/
