Damian Krzeminski wrote:
> I was looking at some unrelated patch and this is what I found in in
> UserPhonebookSearch.java
>
>
> return value + "<a class=\"gwtClickToCall\" onclick=\"clickToCall('"
> + formatPhoneNumber((String) value) + "')\"> <img class=\""
> + "gwtClickToCallImg\" align=\"right\" src=\"" + img + "\" title=\""
> + altText + "\"/> </a>";
>
>
> If we want to use GWT let's write in Java.
> If we want to write in Javascript, let's write in Javascript.
> And if for some reason we need both, let's find a way to combine the two
> without using java as an incredibly inconvenient HTML generator.
>
> I hope this will just magically disappear in the same way it appeared:
> without anyone noticing.
That piece of code looks strangely like something I committed recently ;). I am
working on magically disappearing it right now.
But, this does brings up something I have noticed with GWT. In the demo apps
they have online, it's fairly common to see the widget height, width, margins,
etc. being specified inside the Java class. It is also not uncommon to find
html formatting (e.g. <i/>, <b/> etc.) embedded in there. GWT does provide us
with a lot of hooks that makes this very easy to do. While, I am sure it's
possible to keep a clear separation (by jumping through the various hoops), it
does seem a bit like we are trying to go against the norm of the framework.
At least, been my take on it so far. I will take a closer look at it, and try
and understand it better. Maybe we can come up with a way to extend and improve
upon the widget classes to better suit our needs.
Arjun
_______________________________________________
sipx-dev mailing list [email protected]
List Archive: http://list.sipfoundry.org/archive/sipx-dev
Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
sipXecs IP PBX -- http://www.sipfoundry.org/
