On Fri, 2009-12-04 at 13:51 -0500, Robert Joly wrote: > Hi, > I'm investigating a core dump in sipXproxy and that investigation led me > into the bowels of SipTransaction.cpp which is hostile territory for me. > Working my way through the logic, I stumbled on some inconsistent logic. > Not knowing the inner workings of that piece of logic yet, I thought > that I'd raise it here on the dev list to get your feedback. > > The story goes like this: > > The SipTransaction has a method called > SipTransaction::whatRelation(const SipMessage& message, UtlBoolean > isOutgoing) which characterizes the relationship between 'this' SIP > transaction and the message passed as a parameter based on whether that > message is incoming or outgoing (as given by the isOutgoing parameter). > > I was looking at how the SipTransaction::whatRelation() gets called > within SipTransaction and found that it has two callers: > SipTransaction::handleIncoming() and SipTransaction::handleOutgoing(). > To my surprise, both the handleIncoming() and handleOutgoing() methods > call whatRelation() with the 'isOutgoing' parameter set to TRUE. > Intuitively, I would have expected handleIncoming() to call > whatRelation() with 'isOutgoing' set to FALSE. > > Is this just a naming inconsistency or is there a flaw in the logic > here? >
I'll check. -Kathy _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev sipXecs IP PBX -- http://www.sipfoundry.org/
