Paul Mossman wrote:
> Hi all,
> 
> This request for clarification stems from a new DB table that will be
> added as part of XX-6870: Add SNMP traps as an alarm notification method
> 
> http://sipx-wiki.calivia.com/index.php/SipX_ConfigServer_How_to_change_d
> atabase_schema
> 
> XX-5634 delivered the alarm-groups.sql patch, which has SQL commands to
> create the SMS and Email contact tables.
> 
> I understand that you should never modify an SQL patch file that has
> already been released.  But alarm-groups.sql has not been released yet.
> 
> The SQL commands to create the new SNMP trap receivers table should
> still be put in a new patch file though right?  (Versus added to the
> existing alarm-groups.sql.)

It should be put into a new patch.

> 
> Otherwise, the DB of installations upgrading between minor revisions
> (especially designer environments) would become corrupted.  Where
> alarm-groups.sql has already been marked as applied (in the "patch" DB
> table), it will not be re-applied, so the new schema change would not be
> applied to the DB.  
> 
> As a courtesy sipXconfig strives to facilitate upgrades between minor
> revisions.  (i.e. We try to avoid the above DB corruption.)  But only
> upgrades between released version are officially supported.
> 
> Is that right?
> 

You are absolutely right.
If SQL patch has been around for some time, and if the new SQL patch can be
applied cleanly we always opted for a new patch approach.
It's actually easier to just do the right thing that go through the round
of e-mails from confused developers. We usually have about 15-20 SQL
patches per release, and usually only once or twice we ask people to drop
the DB becuase writing a proper patch would just take to much time and effort.
I doubt SNMP support is such case.

BTW: I am pretty sure XX-6870 was not planned for 4.1.5 iteration.
Damian

_______________________________________________
sipx-dev mailing list [email protected]
List Archive: http://list.sipfoundry.org/archive/sipx-dev
Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
sipXecs IP PBX -- http://www.sipfoundry.org/

Reply via email to