Damian wrote: > I am going to roll back the changes. Please make a branch > based on your commit and get the tests fixed (and hopefully > other issues fixed) and then re-merge it to main.
In my gut I feel this leap was a manageable risk, to avoid having the content fall further out-of-synch with main. But it is clear you feel strongly about it, so I will follow your advice. > Unit tests - and that includes UI unit tests is what make > sure that nothing gets broken when changes are made. I am 100% in support of unit tests, in general. Agreed also that the new layout breaks nearly all the UI unit tests. But my sanity check led me to conclude that nearly all of the UI was not broken. In my judgement, it was quite usable. I may end up eating my words on this, but I suspect most of the broken UI tests do not correspond to broken UI functionality. > PS: > Case in point - I cannot even start sipXconfig now: > [ +/- ] Exception: Missing context resource > '/WEB-INF/common/Dropdown.script'. > > I am pretty sure UI tests would have caught it. I don't think so. The svnmerge.py seems to have omitted the 'svn add' for this file, and a few others. I'm pretty sure the UI tests cannot detect that your installation was built with source files that are not in the svn/git changeset. (But wouldn't that be an excellent test to have!) -Paul [email protected] _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev sipXecs IP PBX -- http://www.sipfoundry.org/
