Mircea Carasel wrote: > On Thu, Jan 7, 2010 at 10:54 PM, Arjun Nair <[email protected]> wrote: >> The User Contact Information REST API returns, amongst other things, the >> Gravatar URL associated with the user. This URL is explicitly calculated and >> added in the ContactInformationResource class. XX-5552[1] now adds this >> info to the UserPhonebook REST API. Here again, the Gravatar URL has to be >> explicitly calculated and added in the UserPhonebookSearchResource class. I >> propose abstracting this away to the AddressBookEntry class. Add a string >> attribute m_avatar to AddressBookEntry, and anytime we set an user email >> (AddressBookEntry.setEmailAddress), we calculate and set the m_avatar >> attribute as well. >> > > This looks like a good idea to me. > >> One major change this would bring is that the <avatar> element will now be a >> child element of <contact-information>. Consumers of the Contact Information >> API (/my/contact-information) would have to update their code to take this >> into account. > If I understood correctly - <avatar> element is already a child of > <contact-information>. There are test cases with this: > > /sipXconfig-web/test/org/sipfoundry/sipxconfig/rest/contact-information-branch.rest.test.xml > > So I believe there is no change needed. > Also, you can check: http://track.sipfoundry.org/browse/XX-6950
Ah, yes, you are correct. This is indeed the case now. Thanks for pointing it out! Arjun _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev sipXecs IP PBX -- http://www.sipfoundry.org/
