-----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Nair, Arjun AVAYA (CAR:9D30) Sent: Monday, February 22, 2010 5:37 PM To: Mossman, Paul AVAYA (CAR:9D30); Cristian Starasciuc Cc: [email protected] Subject: [sipX-dev] XX-7659 Branch address is not propagated to the phonebook
http://code.sipfoundry.org/changelog/sipXecs?cs=18068 > Couple of comments about the commit: > 1. It breaks the phonebook. In PhonebookManager.convertPhonebookEntries(Collection<PhonebookEntry> entriesList), the entriesList can contain > entries imported from files, google accounts, etc. This will cause a null pointer exception in line 759 -- "user.getBranch()", as these imported > contacts don't have a user associated with them. 2. More importantly, we shouldn't have to explicitly make accommodation for AddressBookEntry.useBranchAddress everywhere. This should be abstracted away at some higher level, where by the AddressBookEntry.getOfficeAddress() function will account for the useBranchAddress attribute and return back the correct address. We should not have to check and make provisions for it every time we call AddressBookEntry.getOfficeAddress(). We are already doing this in the ContactInformationResource class, let's not introduce it in the PhonebookManager as well. > If no one has any objections, I am going to revert the commit and re-open the issue. +1. Let's do it in a proper way. Huijun _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev sipXecs IP PBX -- http://www.sipfoundry.org/
